forked from git/git
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the filesystem cache (fscache) in refresh_index(). #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On file systems that support it, this can dramatically speed up operations like add, commit, describe, rebase, reset, rm that would otherwise have to lstat() every file to "re-match" the stat information in the index to that of the file system. On a synthetic repo with 1M files, "git reset" dropped from 52.02 seconds to 14.42 seconds for a savings of 72%. Signed-off-by: Ben Peart <[email protected]>
I like where this is going, but this kind of change already caused one serious regression that had to be reverted in one big hurry. So I would like to spend some quality time reviewing this in-depth, and I will most likely find time to do that toward the end of next week. |
dscho
approved these changes
Sep 27, 2018
@@ -1547,6 +1548,7 @@ int refresh_index(struct index_state *istate, unsigned int flags, | |||
|
|||
replace_index_entry(istate, i, new_entry); | |||
} | |||
enable_fscache(0); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Sep 27, 2018
When FSCache is enabled, commands such as `add`, `commit, and `reset` [are now much faster](git-for-windows/git#1827). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Oct 10, 2018
Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 12, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
that referenced
this pull request
Oct 12, 2018
Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 19, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 20, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
that referenced
this pull request
Nov 21, 2018
Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 23, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 30, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 1, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 9, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 15, 2018
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 25, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 16, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 16, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 16, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 17, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 17, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 19, 2024
Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 30, 2024
…_index Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 31, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 31, 2024
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 1, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 2, 2025
Enable the filesystem cache (fscache) in refresh_index().
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 3, 2025
Enable the filesystem cache (fscache) in refresh_index().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On file systems that support it, this can dramatically speed up operations
like add, commit, describe, rebase, reset, rm that would otherwise have to
lstat() every file to "re-match" the stat information in the index to that
of the file system.
On a synthetic repo with 1M files, "git reset" dropped from 52.02 seconds to
14.42 seconds for a savings of 72%.
Signed-off-by: Ben Peart [email protected]