Revert "reset.c: enable fscache" #1445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fcba80a. Usinsg fscache for reset broke git worktree, git stash. Signed-off-by: Takuto Ikuta <[email protected]>
|
I re-did this patch with more information and marked up as a |
dscho
added a commit
that referenced
this pull request
Jan 22, 2018
The recent speedup to `git reset` sadly broke things, as the cached stat data is no longer accurate after writing the file(s). And that is exactly what `git reset` does: writing the file(s). This patch is identical to the one provided in #1445 but added a bit more detailed information, as well as marking it as a fixup so that the next merging-rebase will drop the patch altogether. This fixes #1437 and #1440. Signed-off-by: Johannes Schindelin <[email protected]>
|
As mentioned a couple of minutes ago, I re-did this revert to include more information. Please note that I am still very much interested in a speedup by introducing fscache into this code path! I just think we have to be a bit more careful how we update the stat data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fcba80a.
Usinsg fscache for reset broke git worktree, git stash. #1437 #1440
Signed-off-by: Takuto Ikuta [email protected]