-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring plugins up to date, fix 2 javadoc issues, Require maven 3.2.5 #622
Conversation
The root is not oss-parent.
While true, that isn't going to be fixed. Jaccoc has been the defaco for years now. The comment itself serves no purpose here as it's completely unlikely this will ever be switched back. Cobertura doesn't support java 8. We are at 13 now and 14 in 3 months. The cobertura project is long EOL. Also, project is nearly 5 years without a commit.
There is no real reason to support prior to this and maven core plugins are starting to require at least this level.
Most of maven requires at least 3.2.5 now. Many are at 3.3.9 or better. There is no reason to support such old 3.1.1 or before.
not sure why but my fork was ok, but PR here failed as not compatible with really old end of life versions. Maven is starting to enforce at least 3.2.5 and I find it hard to believe there is usage before that so just bumping that up. Also added maven 3.9.2 to build process which is where further issues show up beyond the recent pull requests for similar reasons. |
Hello, A Anyhow, github agrees with your changes and they look very reasonable for me too! I think what I would like to do, is to release the version as is (so release a 6.0.0) without those changes and only after get them integrated. That way users still have a version if they want to use older maven things, but I agree it's time to drop some old stuff. Based on https://maven.apache.org/docs/history.html
it feels this plugin could then also require a
but again this is some detail I can take care of. Thanks for getting this started! Will release 6.0.0 now. |
Thanks again, 6.0.0 is now released and available. Thus I'm going ahead and merge this for the upcomming 7.0.0 release :-) Since maven 4.X is still in alpha I'll wait until the first official release. |
Thanks @TheSnoozer . Main concerns with maven 3.9.x good with 6.0.0 release. Rest later is good too. Thank you for quick response here and thanks for pointing out this build has submodules 👍 |
Brought all plugins up to date. Adjusted the min maven so it can still run tests to confirm really old end of life maven versions still work. Not this work is important given maven 3.9.0+ requirements and upcoming maven 4.
The release process will still complain with warnings if using maven 3.9.x. This has to do with profiles in oss parent that should be removed and directly used as that is long obsolete as stated by nexus. For now left it with just the in-line build plugins being fully addressed.
It would further be nice to get a release shortly after this although I see possibly some larger change for 6.x, possible that can drop back and be released or go as-is. Either way this plugin current is vocal due to maven changes which only can be resolved by being up to date and releasing new version.
One note: while GHA works, I was entirely unable to build locally using windows before I even touched any updates. Tests simply do not work, guessing some other setup must exist first as it complained in regards to the following....
All seem similar and there is no file in that location.