-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport the fix for Maven 3.9.2 warnings to 5.0.x branch #630
Comments
I have created a version5.x-branch now. For documentation purposes I have created the branch from
For a full change-set review: I also couldn't resist to add tests for java 11-20 and maven 3.1.0-alpha-1 -> 4.0.0-alpha-5. Please feel free to raise any objections to the current change set in the version5.x branch. |
Getting the Maven 3.9 warning fixed in 5.x would be very much appreciated, indeed. Thanks @TheSnoozer! |
Looks good to me! Thank you! |
Thanks for your patience with me. <dependency>
<groupId>io.github.git-commit-id</groupId>
<artifactId>git-commit-id-maven-plugin</artifactId>
<version>5.0.1</version>
</dependency> The only actual change is the backport of #616. For a full change-set review: As outlined above I'm not too sure if this version will be supported / work with maven 4.X. As of now it does, but it may stop for random reasons. Let me know if you have any other questions and please feel free to raise any other problem or request as new issue :-) Happy coding! |
Describe the release details (required)
There is issue #615 that is fixed in 6.0.0.
Is it possible to backport the fix #616 to the 5.0.x branch (e.g. with Release 5.0.1)?
The reason for this request is that
git-commit-id-maven-plugin
5.0.0 is used by Spring Boot 3.1.x release that happened not long time ago, and in the near future will not be updated togit-commit-id-maven-plugin
6.0.0 because it's a major version change.See spring-projects/spring-boot#35605 for the context.
The text was updated successfully, but these errors were encountered: