-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split files and big types #964
Split files and big types #964
Conversation
Two new options have been added: --splitFiles to split the client code generation into multiple files --enableFmt to disable formatting the generated files with scalafmt The huge gitlab schema compiled in the scripted tests has been converted to use these new options.
i.e. types with more than 22 fields / function args / selection args. The limit has been overcome by encapsulating the arguments inside new case classes (that haven't the 22 function arguments limit) when needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a real codebase, excellent!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks. I will cancel the doc generation step when I merge this so that docs aren't updated until the next release.
This is a merge of my two other PRs plus an improved check on scripted tests.