Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split files and big types #964

Merged
merged 9 commits into from
Jul 12, 2021

Conversation

alexdupre
Copy link
Contributor

This is a merge of my two other PRs plus an improved check on scripted tests.

alexdupre and others added 8 commits July 9, 2021 15:54
Two new options have been added:
--splitFiles to split the client code generation into multiple files
--enableFmt  to disable formatting the generated files with scalafmt

The huge gitlab schema compiled in the scripted tests has been converted
to use these new options.
i.e. types with more than 22 fields / function args / selection args.

The limit has been overcome by encapsulating the arguments inside new
case classes (that haven't the 22 function arguments limit) when needed.
Copy link
Contributor

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a real codebase, excellent!

Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

docs/docs/client.html Outdated Show resolved Hide resolved
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. I will cancel the doc generation step when I merge this so that docs aren't updated until the next release.

@ghostdogpr ghostdogpr merged commit 515292e into ghostdogpr:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants