Add support to split the single client file into multiple files. #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new options have been added: --splitFiles to split the client code generation into multiple files --enableFmt to disable formatting the generated files with scalafmt The huge gitlab schema compiled in the scripted tests has been converted to use these new options.
ghostdogpr
reviewed
Jul 9, 2021
blast-hardcheese
suggested changes
Jul 9, 2021
There was a problem hiding this comment.
Needs alexdupre#1 otherwise the sbt plugin will error if splitFiles(true) is used.
One question as well
| equalTo( | ||
| List( | ||
| "package" -> """package object test { | ||
| | type Character |
There was a problem hiding this comment.
What's the utility of rendering a bare type like this in a package object?
|
I'll review everything in #964 so let's close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new options have been added:
--splitFiles to split the client code generation into multiple files
--enableFmt to disable formatting the generated files with scalafmt
The huge gitlab schema compiled in the scripted tests has been converted
to use these new options.