Exposing a distinct "value" parameter for enumeration members, to avoid relying on default toString() #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
def value: String
on containing enumeration could be aval value: String
if you prefer. I think having a weak reference there is better for some reason, but I can't remember why or if this is true.Option[A]
orList[A]
or otherwise, but relying on the default.toString()
doesn't flag this as an error. This also provides an alternative for those using wartremover'sToString
wart, which prevents relying on the defaulttoString
as well.This was able to be merged without conflict after applying #934, another reason for not changing too much about emitted classes