Exposing the set of members of emitted enumerations #934
Conversation
blast-hardcheese
force-pushed
the
expose-all-enum-members-as-vector
branch
from
98ba84d to
aed060f
Compare
| @@ -380,6 +380,10 @@ object ClientWriter { | |||
| .map(v => s"""case ${typedef.name}.${safeEnumValue(v.enumValue)} => __EnumValue("${v.enumValue}")""") | |||
| .mkString("\n")} | |||
| } | |||
|
|
|||
| val values: Vector[${enumName}] = Vector(${typedef.enumValuesDefinition | |||
There was a problem hiding this comment.
How about a Set instead of Vector?
There was a problem hiding this comment.
It's possible to go from Vector to Set but not the other way around, I believe this is why existing enumeration implementations expose their members as sequences (scala enumerations and scalapb being two examples)
There was a problem hiding this comment.
I agree with you that people shouldn't depend on the ordering of members of an enumeration, but preventing them from doing so at all is just waiting for someone to come and ask for that feature, then breaking all consumers who are already using whatever implementation we decide on here.
There was a problem hiding this comment.
Yeah, I don't think it's right to expect any kind of order but I don't have strong feelings about it. Fine to merge like this.
This is needed for more dynamic mapping of known values in enumerations. Example:
Again, I'm still onboarding onto GraphQL workflows, so if this PR doesn't make sense, thank you for your patience.