Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats-parse scala3 #850

Merged
merged 6 commits into from
May 7, 2021
Merged

cats-parse scala3 #850

merged 6 commits into from
May 7, 2021

Conversation

timzaak
Copy link
Contributor

@timzaak timzaak commented Apr 19, 2021

ref #834

@ghostdogpr
Copy link
Owner

Great! Can you run sbt fmt to fix the linting errors and see if there is any other error?

Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 suggestions to make it compile with Scala 3

Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the suggestions and it's green so I will merge. Thank you!

@ghostdogpr ghostdogpr merged commit e203073 into ghostdogpr:scala3 May 7, 2021
ghostdogpr added a commit that referenced this pull request May 10, 2021
* Initial setup

* fmt

* Fix CI

* Move stuff

* Simplify

* Fix CI

* Upgrade Scala 3 to RC2

* gqldoc macro for Scala 3 (#849)

* Implement derivation for SubscriptionSchema

* Implement ArgBuilder derivation

* Polishing

* Schema derivation

* Remove test code

* WIP Schema

* Enable tests on Scala 3

* Uncomment some tests

* Remove logic for value classes since it's not supported

* Fix ExecutionSpec

* Fix ValidationSchemaSpec

* Enable client on Scala 3

* Remove federation from Scala 3

* Enable Scala 3 on Caliban Client for Scala.js

* Simplify derivation and make it work with Scala enums

* Exclude test for now

* Remove import

* cats-parse scala3 (#850)

* bak cat-parse

* merge scala3 branch

* update cats-parse

* Update core/src/main/scala-3/caliban/parsing/Parser.scala

* Update core/src/main/scala-3/caliban/parsing/Parser.scala

Co-authored-by: Pierre Ricadat <[email protected]>

* Enable tests

* Unignore last ignored test

* Fix merge issue

* Cosmetic changes

* fmt

* Update docs

Co-authored-by: Javier Martínez <[email protected]>
Co-authored-by: timzaak <[email protected]>
@timzaak timzaak deleted the cat-parse-scala3 branch April 28, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants