Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3 Support #847

Merged
merged 33 commits into from
May 10, 2021
Merged

Scala 3 Support #847

merged 33 commits into from
May 10, 2021

Conversation

ghostdogpr
Copy link
Owner

@ghostdogpr ghostdogpr commented Apr 14, 2021 •
edited
Loading

Resolves #631

  • setup Scala 3 compilation
  • split the version-specific code into 2.x and 3.x folders
  • implement parser on Scala 3
    • enable excluded tests that required the parser to run
  • implement derivation on Scala 3
    • SubscriptionSchema
    • ArgBuilder
    • Schema
  • implement gqldoc macro on Scala 3
  • enable tests on Scala 3
  • enable Scala 3 on the client
  • update docs on wrappers (the syntax had to change a little bit)
  • document cases where the derivation doesn't work: value classes, opaque types, nested sealed traits

@ghostdogpr ghostdogpr marked this pull request as draft April 14, 2021 13:48
@ghostdogpr ghostdogpr mentioned this pull request Apr 14, 2021
Closed
2 tasks
@ghostdogpr ghostdogpr mentioned this pull request Apr 18, 2021
Closed
@ghostdogpr
Copy link
Owner Author

Decided to not wait for Magnolia and implement derivation myself using Scala 3 derivation features. SubscriptionSchema and ArgBuilder are done, only the big one Schema left.

ghostdogpr and others added 15 commits May 2, 2021 16:02
@ghostdogpr ghostdogpr marked this pull request as ready for review May 10, 2021 00:36
ghostdogpr added 5 commits May 10, 2021 20:39
@ghostdogpr
Merge branch 'master' into scala3
7c76866 
# Conflicts:
#	build.sbt
#	core/src/main/scala/caliban/schema/Schema.scala
@ghostdogpr
Fix merge issue
d6efe2b
@ghostdogpr
Cosmetic changes
156979f
@ghostdogpr
fmt
6b00ff6
@ghostdogpr
Update docs
6af3e1b
@ghostdogpr ghostdogpr merged commit 2938615 into master May 10, 2021
@ghostdogpr ghostdogpr deleted the scala3 branch May 10, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Scala 3
3 participants
@ghostdogpr @javimartinez @timzaak