Add validation for input objects #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Feb 27, 2020
|
Ah also I think it's okay not to test the duplicate names rule since Caliban will only generate something that doesn't break the rule. |
Yeah I thought about that after writing it , I'll remove it |
mriceron
force-pushed
the
input-object-validation
branch
from
e1416b5 to
8228607
Compare
ghostdogpr
reviewed
Feb 28, 2020
ghostdogpr
changed the title
TobiasPfeifer
added a commit
to TobiasPfeifer/caliban
that referenced
this pull request
Feb 28, 2020
TobiasPfeifer
added a commit
to TobiasPfeifer/caliban
that referenced
this pull request
Feb 28, 2020
ghostdogpr
pushed a commit
that referenced
this pull request
Feb 29, 2020
* initial schema validation method layout for interfaces * reformat code * apply review feedback * interface field and argument name validation * refactor & reuse existing validations after merge of #244 * fix valiation rule * add tests * improve error messages * improve error messages: provide context information * refactoring: duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
Not sure how to test the duplicate names rule without building an invalid Input Object by hand.