-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema validation: interfaces #229
Labels
Comments
I'd like to work on this |
From the given rules its not 100% clear to me if empty names for fields and arguments are valid. Empty names don't make sense imo though. Other thoughts on this? |
@TobiasPfeifer I don't think we need to check for empty names because they are derived from Scala case class parameters and those can't be empty anyway. |
ghostdogpr
pushed a commit
that referenced
this issue
Feb 29, 2020
* initial schema validation method layout for interfaces * reformat code * apply review feedback * interface field and argument name validation * refactor & reuse existing validations after merge of #244 * fix valiation rule * add tests * improve error messages * improve error messages: provide context information * refactoring: duplicate code
Closed by #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
Validator.validateSchema
, verify the rules for interface typesno two fields may share the same name.
characters {"__"} (two underscores).
returns {true}.
characters {"__"} (two underscores).
returns {true}.
The text was updated successfully, but these errors were encountered: