Add cost estimation wrapper #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frekw
reviewed
Nov 29, 2021
frekw
reviewed
Nov 29, 2021
frekw
reviewed
Nov 29, 2021
frekw
reviewed
Nov 29, 2021
There was a problem hiding this comment.
I think it looks really really nice. Both the directives and the multipliers are much nicer than other solutions I've seen. Great work @paulpdaniels! 👏
|
(will review tomorrow or thursday, when work gets quieter 😄) |
paulpdaniels
commented
Nov 30, 2021
paulpdaniels
force-pushed
the
cost-estimation
branch
from
d51e6ed to
dd25ca8
Compare
ghostdogpr
reviewed
Dec 2, 2021
Merged
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 24, 2022
* Add cost estimation wrapper
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 27, 2022
* Add cost estimation wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple cost estimation wrapper for computing the effective cost of executing a query and rejecting it if it is too expensive. Different from
maxDepthormaxFieldsbecause it supports an arbitrary function to determine the cost of the field. Out of the box it provides a simplecostdirective that can be added to fields or types to specify their overall cost to execute. Note, because it is a "speculative" cost it can't take advantage of the actual return values meaning that it relies on the user to apply the correct multipliers and to determine a good metric for assessing a fields cost.