Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor WebGPU Bindings from web_sys #5325

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Vendor WebGPU Bindings from web_sys #5325

merged 1 commit into from
Mar 1, 2024

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Mar 1, 2024 •
edited
Loading

Connections

Closes #5258
Closes #5224

Description

This PR:

  • adds a script to our xtask which automatically vendors the web_sys bindings from a particular checkout of wasm-bindgen.
  • converts our webgpu bindings to those bindings.
  • vastly simplifes the xtask code

We do not use it public-ally, so this is not a breaking change. I plan to backport this.

cc @daxpedda

Testing

Manual testing of WebGPU, CI, and building manually.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner March 1, 2024 05:42
@cwfitzgerald cwfitzgerald added the PR: needs back-porting PR with a fix that needs to land on crates label Mar 1, 2024
@cwfitzgerald cwfitzgerald force-pushed the web-sys-vendor branch 2 times, most recently from 5d6a1cf to 9cfa905 Compare March 1, 2024 06:11
daxpedda
daxpedda approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of --cfg=web_sys_unstable_apis is going to be a big improvment in the user experience!

CHANGELOG.md Show resolved Hide resolved
Wumpf
Wumpf approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, you made this look way more straight forward than I thought it could be. Awesome!!

wgpu/src/backend/webgpu/webgpu_sys/gen_Gpu.rs Show resolved Hide resolved
wgpu/src/backend/webgpu/ext_bindings.rs Show resolved Hide resolved
grovesNL
grovesNL approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks for doing this! I wish vendoring wasn't necessary but it seems like the best path forward until it stabilizes.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) March 1, 2024 20:59
@cwfitzgerald cwfitzgerald merged commit aaf6db6 into gfx-rs:trunk Mar 1, 2024
28 checks passed
cwfitzgerald added a commit to cwfitzgerald/wgpu that referenced this pull request Mar 1, 2024
@cwfitzgerald
Vendor WebGPU Bindings from web_sys (gfx-rs#5325)
5f80832
@cwfitzgerald cwfitzgerald mentioned this pull request Mar 1, 2024
Merged
cwfitzgerald added a commit to cwfitzgerald/wgpu that referenced this pull request Mar 1, 2024
@cwfitzgerald
Vendor WebGPU Bindings from web_sys (gfx-rs#5325)
3e32866
cwfitzgerald added a commit to cwfitzgerald/wgpu that referenced this pull request Mar 1, 2024
@cwfitzgerald
Vendor WebGPU Bindings from web_sys (gfx-rs#5325)
bb09828
@cwfitzgerald cwfitzgerald deleted the web-sys-vendor branch March 1, 2024 22:14
@cwfitzgerald cwfitzgerald removed the PR: needs back-porting PR with a fix that needs to land on crates label Mar 1, 2024
@torokati44 torokati44 mentioned this pull request Mar 1, 2024
Merged
1 task
This was referenced Mar 1, 2024
Merged
Closed
@simbleau simbleau mentioned this pull request Mar 4, 2024
Closed
@hannobraun hannobraun mentioned this pull request Mar 11, 2024
Closed
@xStrom xStrom mentioned this pull request Mar 23, 2024
Merged
@emilk emilk mentioned this pull request Aug 28, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler left review comments

@grovesNL grovesNL grovesNL approved these changes

@daxpedda daxpedda daxpedda approved these changes

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document web-sys version/API mismatch issues
5 participants
@cwfitzgerald @ErichDonGubler @Wumpf @daxpedda @grovesNL