Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-sys doesn't need to be pinned any more #12246

Closed
xStrom opened this issue Mar 1, 2024 · 1 comment · Fixed by #12247
Closed

web-sys doesn't need to be pinned any more #12246

xStrom opened this issue Mar 1, 2024 · 1 comment · Fixed by #12247
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on

Comments

@xStrom
Copy link
Contributor

xStrom commented Mar 1, 2024

The bevy_render package has a strict pin on web-sys:

# web-sys doesn't follow semver for the WebGPU APIs as they are unstable
# Make sure that WebGPU builds work when changing this!
web-sys = { version = "=0.3.67", features = [

This is because wgpu depends on unstable web-sys features which don't follow SemVer.

However things have changed, wgpu has now vendored those bindings. This was also backported and released as v0.19.3.

This means that pinning web-sys is no longer required. The following can be done:

  • Update the wgpu requirement in bevy_render from 0.19.1 to 0.19.3.
  • Remove the web-sys pin.

Doing so will unlock the ability for unrelated projects that have bevy_render in their workspace to finally update their web-sys.

Also, an additional benefit of the aforementioned wgpu change is that wgpu no longer requires you to have --cfg=web_sys_unstable_apis in your RUSTFLAGS.
@xStrom xStrom added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Mar 1, 2024
@alice-i-cecile alice-i-cecile added C-Dependencies A change to the crates that Bevy depends on and removed S-Needs-Triage This issue needs to be labelled labels Mar 1, 2024
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Mar 1, 2024 •
edited
Loading

Sounds good, can you make a PR to change this and I'll point the right folks at it?

@alice-i-cecile alice-i-cecile added the A-Rendering Drawing game state to the screen label Mar 1, 2024
@xStrom xStrom mentioned this issue Mar 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 2, 2024
@xStrom
Update wgpu to v0.19.3 and unpin web-sys. (#12247)
165c360 
# Objective

This PR unpins `web-sys` so that unrelated projects that have
`bevy_render` in their workspace can finally update their `web-sys`.
More details in and fixes #12246.

## Solution

* Update `wgpu` from 0.19.1 to 0.19.3.
* Remove the `web-sys` pin.
* Update docs and wasm helper to remove the now-stale
`--cfg=web_sys_unstable_apis` Rust flag.

---

## Changelog

Updated `wgpu` to v0.19.3 and removed `web-sys` pin.
mockersf pushed a commit that referenced this issue Mar 2, 2024
@xStrom @mockersf
Update wgpu to v0.19.3 and unpin web-sys. (#12247)
f4df8b8 
This PR unpins `web-sys` so that unrelated projects that have
`bevy_render` in their workspace can finally update their `web-sys`.
More details in and fixes #12246.

* Update `wgpu` from 0.19.1 to 0.19.3.
* Remove the `web-sys` pin.
* Update docs and wasm helper to remove the now-stale
`--cfg=web_sys_unstable_apis` Rust flag.

---

Updated `wgpu` to v0.19.3 and removed `web-sys` pin.
spectria-limina pushed a commit to spectria-limina/bevy that referenced this issue Mar 9, 2024
@xStrom @spectria-limina
Update wgpu to v0.19.3 and unpin web-sys. (bevyengine#12247)
1e15d3d 
# Objective

This PR unpins `web-sys` so that unrelated projects that have
`bevy_render` in their workspace can finally update their `web-sys`.
More details in and fixes bevyengine#12246.

## Solution

* Update `wgpu` from 0.19.1 to 0.19.3.
* Remove the `web-sys` pin.
* Update docs and wasm helper to remove the now-stale
`--cfg=web_sys_unstable_apis` Rust flag.

---

## Changelog

Updated `wgpu` to v0.19.3 and removed `web-sys` pin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update wgpu to v0.19.3 and unpin web-sys. xStrom/bevy
2 participants
@xStrom @alice-i-cecile