-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expected_msg_substring
arg. to wgpu_test::fail
#5290
Merged
ErichDonGubler
merged 3 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:fail-test-msg-arg
May 21, 2024
Merged
Add expected_msg_substring
arg. to wgpu_test::fail
#5290
ErichDonGubler
merged 3 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:fail-test-msg-arg
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
area: tests
Improvements or issues with our test suite
kind: refactor
Making existing function faster or nicer
labels
Feb 22, 2024
ErichDonGubler
commented
Feb 22, 2024
ErichDonGubler
commented
Feb 22, 2024
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
2 times, most recently
from
February 26, 2024 17:36
7ff3ce0
to
73fc369
Compare
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
from
March 7, 2024 03:47
73fc369
to
75548ae
Compare
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
2 times, most recently
from
April 2, 2024 01:05
2d21499
to
d538fd2
Compare
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
from
April 18, 2024 14:31
d538fd2
to
134cd76
Compare
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
from
May 8, 2024 21:52
134cd76
to
9547a56
Compare
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
3 times, most recently
from
May 17, 2024 18:17
e88b183
to
e3eaa43
Compare
Wumpf
approved these changes
May 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I did something similar here, but in a less intrusive way (because the pr shouldn't also drag in such a large refactor)
(will happily move my stuff to this new variant once we get the stuff that comes before it merged :/)
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
from
May 21, 2024 20:52
d063f25
to
7bccffb
Compare
ErichDonGubler
force-pushed
the
fail-test-msg-arg
branch
from
May 21, 2024 20:52
7bccffb
to
0031ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: tests
Improvements or issues with our test suite
kind: refactor
Making existing function faster or nicer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Motivated by discussion in (and based on code from) another PR: #5282 (comment)
good first issue
for converting more tests to use specific validation error messages: Good first issue: use concrete error messages forwgpu-test
tests #5727Description
Describe what problem this is solving, and how it's solved.
Until now, we accept any validation failure inside a
callback
passed towgpu_test::fail
. This is a very broad error condition, and may allow errors for the wrong reason. Now, we'd like to tighten up the failures that we actually expect from these tests. Also, this would let us factor out some error scope boilerplate introduced for the tests in #5282.Testing
Explain how this change is tested.
This is a refactor of tests to make them more narrow, and they still pass. ✅
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.Add change toSeems like none should be necessary here?CHANGELOG.md
. See simple instructions inside file.