Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good first issue: use concrete error messages for wgpu-test tests #5727

Closed
ErichDonGubler opened this issue May 22, 2024 · 3 comments · Fixed by #6016
Closed

Good first issue: use concrete error messages for wgpu-test tests #5727

ErichDonGubler opened this issue May 22, 2024 · 3 comments · Fixed by #6016
Assignees
Labels
area: tests Improvements or issues with our test suite good first issue Good for newcomers

Comments

@ErichDonGubler
Copy link
Member

After merging #5290, there are many tests in tests/tests/ that do not specify the text of the expected validation error. This is actually a hole in coverage; if the reason for validation changes, it could potentially be a regression of coverage. We wouldn't be able to detect this without actually checking the content of the validation error!

We should narrow expected validation error texts for these tests.

@ErichDonGubler is happy to act as a mentor for whoever wants to take this on. 🙂

@ErichDonGubler ErichDonGubler added good first issue Good for newcomers area: tests Improvements or issues with our test suite labels May 22, 2024
@dv29
Copy link
Contributor

dv29 commented Jul 21, 2024

can i work on this?

@cwfitzgerald
Copy link
Member

Sure!

@dv29
Copy link
Contributor

dv29 commented Jul 22, 2024

@ErichDonGubler looking for feedback on 6016. I did just one to see if this is correct and/or what need to be changed before i replicate for others

dv29 added a commit to dv29/wgpu that referenced this issue Jul 25, 2024
dv29 added a commit to dv29/wgpu that referenced this issue Jul 25, 2024
dv29 added a commit to dv29/wgpu that referenced this issue Jul 25, 2024
dv29 added a commit to dv29/wgpu that referenced this issue Jul 25, 2024
dv29 added a commit to dv29/wgpu that referenced this issue Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Improvements or issues with our test suite good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants