-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Good first issue: use concrete error messages for wgpu-test
tests
#5727
Labels
Comments
ErichDonGubler
added
good first issue
Good for newcomers
area: tests
Improvements or issues with our test suite
labels
May 22, 2024
7 tasks
can i work on this? |
Sure! |
dv29
added a commit
to dv29/wgpu
that referenced
this issue
Jul 22, 2024
6 tasks
@ErichDonGubler looking for feedback on 6016. I did just one to see if this is correct and/or what need to be changed before i replicate for others |
dv29
added a commit
to dv29/wgpu
that referenced
this issue
Jul 25, 2024
dv29
added a commit
to dv29/wgpu
that referenced
this issue
Jul 25, 2024
dv29
added a commit
to dv29/wgpu
that referenced
this issue
Jul 25, 2024
dv29
added a commit
to dv29/wgpu
that referenced
this issue
Jul 25, 2024
dv29
added a commit
to dv29/wgpu
that referenced
this issue
Jul 25, 2024
ErichDonGubler
pushed a commit
to dv29/wgpu
that referenced
this issue
Jul 26, 2024
ErichDonGubler
pushed a commit
to dv29/wgpu
that referenced
this issue
Aug 16, 2024
ErichDonGubler
pushed a commit
to dv29/wgpu
that referenced
this issue
Aug 16, 2024
ErichDonGubler
pushed a commit
to dv29/wgpu
that referenced
this issue
Aug 16, 2024
ErichDonGubler
pushed a commit
to dv29/wgpu
that referenced
this issue
Aug 16, 2024
ErichDonGubler
pushed a commit
to dv29/wgpu
that referenced
this issue
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
After merging #5290, there are many tests in
tests/tests/
that do not specify the text of the expected validation error. This is actually a hole in coverage; if the reason for validation changes, it could potentially be a regression of coverage. We wouldn't be able to detect this without actually checking the content of the validation error!We should narrow expected validation error texts for these tests.
@ErichDonGubler is happy to act as a mentor for whoever wants to take this on. 🙂
The text was updated successfully, but these errors were encountered: