add debug info for spv-out #2379

wicast · 2023-06-13T03:39:50Z

make the spv with debug info mapping to wgsl

here is the capture file you can try
wgsl_debug_info.zip

teoxoy

Looks great! I left a few minor comments.

Could you also add a test for this? So that we have this as part of our snapshots.

src/lib.rs

src/back/spv/writer.rs

src/back/spv/block.rs

wicast · 2023-06-25T16:03:20Z

I've add some test and re-write the spv writer.
It has some troubles with OpName tracking when it compiles a complex shader see here, some of the local variables are missing,
anyway it's a usable version for debugging shaders.

the complex shader capture with compute shader:
wgsl_terrain.zip

src/back/spv/block.rs

src/back/spv/writer.rs

tests/snapshots.rs

teoxoy

LGTM, thanks!

Gordon-F · 2023-06-29T09:36:03Z

src/back/spv/mod.rs

    let mut w = Writer::new(options)?;
-    w.write(module, info, pipeline_options, &mut words)?;
+
+    if options.flags.contains(WriterFlags::DEBUG) {}


@wicast This empty if looks like a bug

@wicast This empty if looks like a bug

I've made a PR to fix it, alone with the other debug option fix.
BTW, clippy has add needless_if but only in newer version 1.72.0

wicast force-pushed the spv_debug_symbol branch 2 times, most recently from 438f3bc to 33f2cd5 Compare June 13, 2023 04:21

teoxoy suggested changes Jun 20, 2023

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/back/spv/writer.rs Outdated Show resolved Hide resolved

src/back/spv/writer.rs Outdated Show resolved Hide resolved

src/back/spv/writer.rs Outdated Show resolved Hide resolved

src/back/spv/block.rs Outdated Show resolved Hide resolved

wicast added 3 commits June 25, 2023 23:33

feat(spv-out): add debug info for spv-out

b273629

refactor(spv-out): move debug info to params

331df52

test(spv-out): add debug symbol tests

7bda4d2

wicast force-pushed the spv_debug_symbol branch from 33f2cd5 to 7bda4d2 Compare June 25, 2023 15:52

wicast requested a review from teoxoy June 25, 2023 16:06

teoxoy suggested changes Jun 27, 2023

View reviewed changes

src/back/spv/block.rs Outdated Show resolved Hide resolved

src/back/spv/writer.rs Outdated Show resolved Hide resolved

tests/snapshots.rs Outdated Show resolved Hide resolved

refactor(spv-out): change debug skip&simplify test

1c5dc30

wicast requested a review from teoxoy June 28, 2023 10:32

teoxoy approved these changes Jun 28, 2023

View reviewed changes

teoxoy merged commit 25e4f17 into gfx-rs:master Jun 28, 2023

wicast mentioned this pull request Jun 29, 2023

Shader Debug Flag gfx-rs/wgpu#3896

Closed

Gordon-F reviewed Jun 29, 2023

View reviewed changes

wicast mentioned this pull request Oct 25, 2023

Debuggable Shader gfx-rs/wgpu#4561

Open

7 tasks

teoxoy mentioned this pull request Mar 28, 2024

65535 word shader literal limit gfx-rs/wgpu#5390

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add debug info for spv-out #2379

add debug info for spv-out #2379

wicast commented Jun 13, 2023

teoxoy left a comment

wicast commented Jun 25, 2023 •

edited

Loading

teoxoy left a comment

Gordon-F Jun 29, 2023

wicast Jun 29, 2023 •

edited

Loading

add debug info for spv-out #2379

add debug info for spv-out #2379

Conversation

wicast commented Jun 13, 2023

teoxoy left a comment

Choose a reason for hiding this comment

wicast commented Jun 25, 2023 • edited Loading

teoxoy left a comment

Choose a reason for hiding this comment

Gordon-F Jun 29, 2023

Choose a reason for hiding this comment

wicast Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

wicast commented Jun 25, 2023 •

edited

Loading

wicast Jun 29, 2023 •

edited

Loading