Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Add compression to bundler #229

Merged
merged 14 commits into from
Jun 19, 2024
Merged

Add compression to bundler #229

merged 14 commits into from
Jun 19, 2024

Conversation

voltrevo
Copy link
Contributor

@voltrevo voltrevo commented Apr 4, 2024

What is this PR doing?

Changes needed to get compression working with an external bundler. See getwax/bundler#1.

  • Enable specifying external deployments for EntryPoint, AddressRegistry, and BLSSignatureAggregator
  • Improve yarn dev by auto-detecting when a local node is already running elsewhere
  • Random: fix Button.tsx interpreting all keyboard events as a button press
  • Add required buffers to verification and preverification gas
  • Don't send any preverification gas during estimation (related: verificationGasLimit calculation unnecessarily includes preVerificationGas eth-infinitism/bundler#189)
  • Allow string error codes for jsonrpc errors (EIP 1193 says they should be numbers, but the bundler produces errors with string codes)
  • Create deployedAddresses.json upon deployment in packages/plugins
  • Remove erroneous docker stop $CONTAINER || true from start-hardhat.sh (that script doesn't use docker)

How can these changes be manually tested?

Manual test demo

Does this PR resolve or contribute to any issues?

Contributes to #215.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@voltrevo voltrevo mentioned this pull request Apr 4, 2024
2 tasks
@voltrevo voltrevo marked this pull request as ready for review April 4, 2024 06:03
@jacque006 jacque006 merged commit dfce55d into main Jun 19, 2024
2 checks passed
@jacque006 jacque006 deleted the wax-215-add-compression branch June 19, 2024 01:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants