Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wax compression #1

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Add wax compression #1

merged 11 commits into from
Jun 19, 2024

Conversation

voltrevo
Copy link
Collaborator

@voltrevo voltrevo commented Apr 4, 2024

What is this PR doing?

Adds wax compression. This should be considered together with changes made to the wax repo: getwax/wax#229.

  • Add copy of wax compression dir
    • This should be fixed in future by making it available via npm or otherwise
  • Add imports to produce type information for BLSSignatureAggregator, HandleOpsCaller, and HandleAggregatedOpsCaller
  • Add config for new contracts addressRegistry, aggregator (aka BLSSignatureAggregator), handleOpsCaller, handleAggregatedOpsCaller
  • Update local config to match addresses generated by wax repo
  • Update local config to use testabsent instead of testjunk (avoid multiple tools using same EOA)
  • Split out populateBundleTx in BundleManager and rewrite it to handle compression
  • Add support for aggregated transactions (requires calling different contract, previously ignored/rejected aggregate ops and only called entrypoint's handleOps)
  • Add Compressor class to handle details of compression, including many methods basically copied from the wax repo, with adjustments for ethers v5 and different eslint rules
    • This should be fixed in future by making these compression primitives available via the sdk
    • ethers v5 vs v6 is an awkward compatibility issue though, this may require making separate versions for each ethers version (also for other external projects being on different ethers versions)

How can these changes be manually tested?

See instructions on wax PR: getwax/wax#229.

Does this PR resolve or contribute to any issues?

Contributes to getwax/wax#215.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@voltrevo voltrevo mentioned this pull request Apr 4, 2024
2 tasks
@voltrevo voltrevo marked this pull request as ready for review April 4, 2024 06:03
@jacque006 jacque006 merged commit bc04c9f into v0.6 Jun 19, 2024
@jacque006 jacque006 deleted the wax-215-add-compression--v0.6 branch June 19, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants