Add ItchySats App #1149

klochowicz · 2021-12-07T06:09:58Z

App Submission

App name

ItchySats

Version

v0.3.0

One line description of the app

Peer-2-peer derivatives on Bitcoin

Summary of the app

ItchySats enables peer-2-peer CFD trading on Bitcoin using DLCs (discreet log contracts). No account needed, no trusted third-party - just you and your keys.

This is beta software. We tested it on test- and mainnet, but there are no guarantees that it will always behave as expected.
Please be mindful with how much money you trust the application with.
CFDs trading is inherently risky, be sure to read up on it before using this application.

That said: This is pretty awesome, go nuts!

Fund the ItchySats wallet
Open a position
Watch the price go up
Profit

Limitations of the mainnet beta:

You can only open long positions at the moment
Minimum position quantity is $100, maximum $1000
CFDs period ends after 7 days - perpetual positions are in the making :)
The leverage is fixed at 2

We are woking hard on perpetual positions and allowing sell positions.
Update to be expected soon!

Developer name

ItchySats

Requires

Bitcoin Core
Electrum server
LND

256x256 SVG icon

Itchilogo.svg.zip
(as zip as svgur.com is over quota and does not work now...)

Gallery images

(3 screenshots with captions)

"Start it. Trade! It’s that simple"

"Bitcoin CFDs without a middle-man"

"No accounts, just you and your keys!"

I have tested my app on:

aphex3k · 2021-12-11T02:48:37Z

apps/itchysats/docker-compose.yml

+      - ${APP_DATA_DIR}/data:/data
+    command:
+      - --maker=mainnet.itchysats.network:9999
+      - --maker-id=7e35e34801e766a6a29ecb9e22810ea4e3476c2b37bf75882edf94a68b1d9607


What is this id used for?

It's the maker's public key which is needed to have an encrypted connection with the maker behind mainnet.itchysats.network:9999.

klochowicz · 2021-12-13T01:49:49Z

I've force-pushed after rebasing against the recent umbrel master to avoid merge conflicts (no other changes).

lukechilds

This looks great guys, some minor tweaks required.

Btw, I'm unable to test this on my mainnet node, when I try to install I get:

umbrel@umbrel-mainnet:~/umbrel $ ./scripts/app install itchysats
Setting up data dir for app itchysats...
sending incremental file list

sent 126 bytes  received 13 bytes  278.00 bytes/sec
total size is 654  speedup is 4.71
Pulling images for app itchysats...
Pulling web ... done
Starting app itchysats...
Creating itchysats_web_1 ... error

ERROR: for itchysats_web_1  Cannot start service web: OCI runtime create failed: invalid mount {Destination:data Type:bind Source:/var/lib/docker/volumes/3373facda23457bc501bfff215d91789cc1ee4f20c043d4b929bed56fc691305/_data Options:[rbind]}: mount destination data not absolute: unknown

ERROR: for web  Cannot start service web: OCI runtime create failed: invalid mount {Destination:data Type:bind Source:/var/lib/docker/volumes/3373facda23457bc501bfff215d91789cc1ee4f20c043d4b929bed56fc691305/_data Options:[rbind]}: mount destination data not absolute: unknown
ERROR: Encountered errors while bringing up the project.

I was however able to succesfully install on my testnet node, so seems like I'm hitting some strange Docker bug and not an issue with your app specifically. Just checking you were able to install ok?

Also are you able to allow edits from maintainers so I can push to this PR branch?

Edit: Also one other thing, I noticed there's no authentication, so currently any user on the local network, or anyone that gets access to the users remote Tor address, can open positions and withdraw funds from the users account. We pass in an $APP_PASSWORD env var that is a 128 bit random hex string unique to each app which apps can optionally use to add authentication. The plain text password will be show to the user in the dashboard for them to easily copy/paste it in when opening the app. I think ItchySats should make use of this, or alternatively implement some other type of custom auth. In it's current state it's quite risky, e.g a user that shares a screenshot of ItchySats on Twitter when accessing over Tor (and therefore accidentily leaking their Tor hidden service address) could have their account drained.

lukechilds · 2021-12-23T15:47:24Z

apps/registry.json

+        "developer": "ItchySats",
+        "website": "https://itchysats.network",
+        "dependencies": [
+            "bitcoind",


This doesn't directly depend on bitcoind right? Only indirectly via Electrum? If so we can remove this dependency.

Suggested change

"bitcoind",

👍 b8619fa (#1149)

lukechilds · 2021-12-23T15:48:52Z

templates/torrc-apps-3-sample

+
+# itchysats Hidden Service
+HiddenServiceDir /var/lib/tor/app-itchysats
+HiddenServicePort 80 <app-itchysats-ip>:<app-itchysats-port>


This should be the port on the container not on the host.

Suggested change

HiddenServicePort 80 <app-itchysats-ip>:<app-itchysats-port>

HiddenServicePort 80 <app-itchysats-ip>:8000

👍 c91214d (#1149)

lukechilds · 2021-12-24T04:17:16Z

scripts/configure

@@ -218,6 +218,8 @@ APP_SYNCTHING_PORT="8384"
 APP_SYNCTHING_SYNC_PORT="22000"
 APP_UPTIME_KUMA_PORT="8385"
 APP_UPTIME_KUMA_IP="10.21.21.62"
+APP_ITCHYSATS_IP="10.21.21.63"


There is an IP collision with $APP_RIDE_THE_LIGHTNING_BOLTZ_IP in master here.

Suggested change

APP_ITCHYSATS_IP="10.21.21.63"

APP_ITCHYSATS_IP="10.21.21.64"

👍 218b8dd (#1149)

lukechilds · 2021-12-24T09:12:21Z

Also where's the best place to DM you guys for some more general questions on ItchySats?

lukechilds · 2021-12-24T09:19:39Z

Also what license is the ItchySats codebase licensed under? Currently I don't see a license file on your repo.

lukechilds · 2021-12-24T10:47:48Z

Seems like the volume issue is that this line https://github.com/itchysats/itchysats/blob/61c7bcbb322ab4adc43c199210a423287862a8d1/Dockerfile#L13 should be VOLUME /data (absolute instead of relative path).

Fixed here: get10101/itchysats#971

lukechilds · 2021-12-24T11:10:14Z

Hitting this trying to open a position:

Is that expected currently if the app is still in testing and you don't have a lot of funds on the maker node or is something wrong?

Also seeing lots of stuff like this spamming the logs:

web_1  | 2021-12-24 11:09:36  WARN daemon::tokio_ext: Task failed: Failed to GET https://h00.ooo/x/BitMEX/BXBT/2021-12-26T12:00:00.price?n=20: error sending request for url (https://h00.ooo/x/BitMEX/BXBT/2021-12-26T12:00:00.price?n=20): error trying to connect: dns error: failed to lookup a
ddress information: Temporary failure in name resolution: error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution: dns error: failed to lookup address information: Temporary failure in name resolution: failed to lookup address informati
on: Temporary failure in name resolution
web_1  | 2021-12-24 11:09:36  WARN daemon::tokio_ext: Task failed: Failed to GET https://h00.ooo/x/BitMEX/BXBT/2021-12-31T03:00:00.price?n=20: error sending request for url (https://h00.ooo/x/BitMEX/BXBT/2021-12-31T03:00:00.price?n=20): error trying to connect: dns error: failed to lookup a
ddress information: Temporary failure in name resolution: error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution: dns error: failed to lookup address information: Temporary failure in name resolution: failed to lookup address informati
on: Temporary failure in name resolution
web_1  | 2021-12-24 11:09:36  WARN daemon::tokio_ext: Task failed: Failed to GET https://h00.ooo/x/BitMEX/BXBT/2021-12-26T15:00:00.price?n=20: error sending request for url (https://h00.ooo/x/BitMEX/BXBT/2021-12-26T15:00:00.price?n=20): error trying to connect: dns error: failed to lookup a
ddress information: Temporary failure in name resolution: error trying to connect: dns error: failed to lookup address information: Temporary failure in name resolution: dns error: failed to lookup address information: Temporary failure in name resolution: failed to lookup address informati
on: Temporary failure in name resolution
web_1  | 2021-12-24 11:09:36 DEBUG daemon::oracle: Fetching announcement for /x/BitMEX/BXBT/2021-12-30T11:00:00.price?n=20
web_1  | 2021-12-24 11:09:36 DEBUG daemon::oracle: Fetching announcement for /x/BitMEX/BXBT/2021-12-29T12:00:00.price?n=20
web_1  | 2021-12-24 11:09:36 DEBUG daemon::oracle: Fetching announcement for /x/BitMEX/BXBT/2021-12-29T13:00:00.price?n=20
web_1  | 2021-12-24 11:09:36 DEBUG daemon::oracle: Fetching announcement for /x/BitMEX/BXBT/2021-12-29T14:00:00.price?n=20

1010Tom · 2021-12-24T16:02:00Z

Hi @lukechilds

thanks for reviewing our PR. I've fixed your comments in separate commits.

Regarding the authentication: that's a good point. We do have a ticket for this get10101/itchysats#609 . Do you want this in the first release or is ok if we postpone it for the next release?

Also where's the best place to DM you guys for some more general questions on ItchySats?

You can find us on matrix: https://matrix.to/#/#comit-hermes:matrix.org or reach us via telegram https://t.me/joinchat/ULycH50PLV1jOTI0

Is that expected currently if the app is still in testing and you don't have a lot of funds on the maker node or is something wrong?

This looks correct and maybe we should better displayed the "No Liquidity" error a warning and not as an error: We are testing with safe amounts at the moment: $100-$1000 and the taker will create a new offer after a few seconds.

The error below (Announcement not found) was not expected :/ It looks like there was a DNS error on your machine?

Also what license is the ItchySats codebase licensed under? Currently I don't see a license file on your repo.

Let me get back to you on that. Should be an open source license.

p.s. merry christmas :)

bonomat · 2021-12-27T06:05:08Z

Hi @lukechilds, thanks for giving ItchySats a try.

We have 3 versions running. As far as I remember, we started with version v0.4.8 but then upgraded to v0.4.9. All three version were running without any issues.

Regarding the DNS errors: it looks weird but I think we have seen this before.
Can you open a ticket on our repository and attach some more logs please? Maybe there is something useful in there before the lines you shared above.
Also, it would be good to know if you had a "clean" umbrel node or if you changed something in the dns settings.

Regarding authentication: I would opt for a nginx proxy using APP_PASSWORD for now until we get get10101/itchysats#609 implemented. This should be faster and we can then ship the authentication with a new release.

Also are you able to allow edits from maintainers so I can push to this PR branch?

@klochowicz : please enable edits for maintainers

971: Fix volume path r=bonomat a=lukechilds Using the relative path like this instead of an abolute path when trying to start a container I just get the error: ``` ERROR: for itchysats_web_1 Cannot start service web: OCI runtime create failed: invalid mount {Destination:data Type:bind Source:/var/lib/docker/volumes/3373facda23457bc501bfff215d91789cc1ee4f20c043d4b929bed56fc691305/_data Options:[rbind]}: mount destination data not absolute: unknown ERROR: for web Cannot start service web: OCI runtime create failed: invalid mount {Destination:data Type:bind Source:/var/lib/docker/volumes/3373facda23457bc501bfff215d91789cc1ee4f20c043d4b929bed56fc691305/_data Options:[rbind]}: mount destination data not absolute: unknown ERROR: Encountered errors while bringing up the project. ``` It seems like only certain versions of Docker fail without this, I can get your current Docker image to run on some machines but not others without this change. However with this change it runs correctly on all of my machines. Related: getumbrel/umbrel#1149 (review) Co-authored-by: Luke Childs <[email protected]>

lukechilds · 2021-12-27T09:52:18Z

p.s. merry christmas :)

Thanks! You too, hope you guys had a great Christmas!

Regarding the authentication: that's a good point. We do have a ticket for this get10101/itchysats#609 . Do you want this in the first release or is ok if we postpone it for the next release?
-- @itchymax

To be honest it's up to you guys but I'd strongly advise adding some sort of basic auth to the initial release. Or atleast showing a big warning that this is an initial beta release with no auth if you decide not to.

This sounds like a great compromise though:

Regarding authentication: I would opt for a nginx proxy using APP_PASSWORD for now until we get get10101/itchysats#609 implemented. This should be faster and we can then ship the authentication with a new release.
-- @bonomat

Re DNS

The error below (Announcement not found) was not expected :/ It looks like there was a DNS error on your machine?
-- @itchymax

Regarding the DNS errors: it looks weird but I think we have seen this before.
Can you open a ticket on our repository and attach some more logs please? Maybe there is something useful in there >before the lines you shared above.
Also, it would be good to know if you had a "clean" umbrel node or if you changed something in the dns settings.
-- @bonomat

I haven't changed any DNS settings. I just remembered some users had some issues with the mempool app that were resolved by changing Docker DNS settings. Sounds like this could be related. Let me try the proposed fix and see if that resolves the ItchySats issue.

lukechilds · 2021-12-27T10:52:18Z

Also re this:

We have 3 versions running. As far as I remember, we started with version v0.4.8 but then upgraded to v0.4.9. All three version were running without any issues.

Assuming that version is maker specific? Cos this PR currently includes ghcr.io/itchysats/itchysats/taker:0.3.0.

bonomat · 2021-12-27T10:58:37Z

Also re this:

We have 3 versions running. As far as I remember, we started with version v0.4.8 but then upgraded to v0.4.9. All three version were running without any issues.

Assuming that version is maker specific? Cos this PR currently includes ghcr.io/itchysats/itchysats/taker:0.3.0.

sorry, I meant Umbrel version.

lukechilds · 2021-12-27T11:24:10Z

sorry, I meant Umbrel version.

Ah got it.

Btw just seen you have ghcr.io/itchysats/itchysats/taker:0.3.2 published, we should update this PR to that, right?

lukechilds · 2021-12-27T11:29:28Z

Ok so this #1076 (comment) fixed the DNS issue for me, so seems unrelated to ItchySats and some sort of internal Umbrel DNS issue. Looking into it.

Opened a position! Exciting stuff 🚀

bonomat · 2021-12-27T11:49:11Z

Re

Btw just seen you have ghcr.io/itchysats/itchysats/taker:0.3.2 published, we should update this PR to that, right?

yes indeed: @itchymax / @klochowicz please upgrade to 0.3.2.

Ok so this #1076 (comment) fixed the DNS issue for me, so seems unrelated to ItchySats and some sort of internal Umbrel DNS issue. Looking into it.

Opened a position! Exciting stuff 🚀

Great that it worked and let's go Bitcoin ! 🚀

lukechilds · 2021-12-27T12:45:20Z

Also guys, looks like you are generating the seed randomly on first start. This is fine, but we also expose $APP_SEED which is a hex hex string deterministically derived from the users Umbrel seed. If you wanted to you could make use of this. It would mean that if a user's Umbrel broke and they setup a new one and imported their previous Umbrel seed, the ItchySats app would then derive the same wallet as the previous install and reover the previous funds.

1010Tom · 2021-12-28T09:05:19Z

Also guys, looks like you are generating the seed randomly on first start. This is fine, but we also expose $APP_SEED which is a hex hex string deterministically derived from the users Umbrel seed. If you wanted to you could make use of this. It would mean that if a user's Umbrel broke and they setup a new one and imported their previous Umbrel seed, the ItchySats app would then derive the same wallet as the previous install and reover the previous funds.

That's cool. I've created a ticket for this: get10101/itchysats#978

lukechilds · 2021-12-28T10:51:44Z

@bonomat just FYI the DNS issue seems like a DNS issue on my network unrelated to ItchySats and Umbrel.

Viewing https://outcome.observer/h00.ooo/x/BitMEX/BXBT in my browser on my workstation on the same network as my Umbrel gives this error:

Changing to a different network or using Tor Browser allows me to view the price feed correctly. You said you had reports of this issue before, maybe there is some sort of problem with the DNS configuration of the price feed server causing it to not work with some ISPs? Any ideas?

scratchscratchscratchy · 2021-12-29T04:08:11Z

@lukechilds with upgrading to version 0.3.3 we restrict the API by basic auth (as discussed in comments above). Password is set to $APP_PASSWORD, username defaulted in registry to itchysats.

I just tested upgrading my umbrel and it worked fine displaying the password/username in the appstore.

I think with adding this we should be able to merge. Please let me know if there is anything else needed :)

Includes using `$APP_PASSWORD` to restrict access to ItchySats within Umbrel by basic auth.

klochowicz · 2021-12-29T05:52:30Z

@lukechilds @itchymax @bonomat Unfortunately I don't seem to be able to allow pushing to this branch as the PR was created from org repo instead of personal one. I can resubmit the PR from a personal github account to allow this, but I'm not sure if it's worth the effort?

lukechilds · 2021-12-29T09:30:47Z

@klochowicz ah yes, just seen this isaacs/github#1681 that sucks.

Ok no worries, no need for a new PR, good to keep the history here, I can just submit a PR to your org repo if I need to do any changes.

lukechilds · 2021-12-29T09:31:38Z

I think with adding this we should be able to merge. Please let me know if there is anything else needed :)

@scratchscratchscratchy awesome! Testing now!

lukechilds

Tested and working great. Amazing stuff guys, really excited to ship this!

klochowicz marked this pull request as draft December 7, 2021 06:10

This comment has been minimized.

Sign in to view

1010Tom mentioned this pull request Dec 7, 2021

Create an Umbrel plugin 🥳 get10101/itchysats#680

Closed

lukechilds added the app submission A brand new app submission label Dec 7, 2021

scratchscratchscratchy force-pushed the itchysats branch from a0a82e2 to 35453b2 Compare December 8, 2021 23:19

klochowicz force-pushed the itchysats branch from 4b9fb5a to ba78533 Compare December 9, 2021 03:52

klochowicz marked this pull request as ready for review December 9, 2021 03:55

aphex3k reviewed Dec 11, 2021

View reviewed changes

klochowicz force-pushed the itchysats branch from ba78533 to 48c7970 Compare December 13, 2021 01:48

lukechilds requested changes Dec 24, 2021

View reviewed changes

lukechilds mentioned this pull request Dec 24, 2021

Fix volume path get10101/itchysats#971

Merged

bonomat mentioned this pull request Dec 27, 2021

Add taker http basic auth get10101/itchysats#976

Closed

1010Tom force-pushed the itchysats branch from c91214d to 8beafdc Compare December 28, 2021 08:59

1010Tom mentioned this pull request Dec 28, 2021

Provide seed as argument get10101/itchysats#978

Closed

scratchscratchscratchy force-pushed the itchysats branch from 42b6e9e to 64d6a05 Compare December 29, 2021 03:57

1010Tom and others added 3 commits December 29, 2021 15:16

Add ItchySats App

cfa0d1d

Upgrade itchysats to 0.3.2

8e43f78

Upgrade to 0.3.3

2109004

Includes using `$APP_PASSWORD` to restrict access to ItchySats within Umbrel by basic auth.

scratchscratchscratchy force-pushed the itchysats branch from 64d6a05 to 2109004 Compare December 29, 2021 04:16

lukechilds approved these changes Dec 30, 2021

View reviewed changes

lukechilds merged commit 3addd45 into getumbrel:master Dec 30, 2021

bonomat mentioned this pull request Jan 11, 2022

Add ItchySats App get10101/umbrel#1

Closed

bonomat deleted the itchysats branch January 11, 2022 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ItchySats App #1149

Add ItchySats App #1149

klochowicz commented Dec 7, 2021 •

edited

Loading

This comment has been minimized.

aphex3k Dec 11, 2021

1010Tom Dec 12, 2021

klochowicz commented Dec 13, 2021

lukechilds left a comment •

edited

Loading

lukechilds Dec 23, 2021 •

edited

Loading

1010Tom Dec 24, 2021 •

edited

Loading

lukechilds Dec 23, 2021

1010Tom Dec 24, 2021 •

edited

Loading

lukechilds Dec 24, 2021

1010Tom Dec 24, 2021

lukechilds commented Dec 24, 2021

lukechilds commented Dec 24, 2021

lukechilds commented Dec 24, 2021

lukechilds commented Dec 24, 2021

1010Tom commented Dec 24, 2021

bonomat commented Dec 27, 2021

lukechilds commented Dec 27, 2021

lukechilds commented Dec 27, 2021

bonomat commented Dec 27, 2021

lukechilds commented Dec 27, 2021

lukechilds commented Dec 27, 2021

bonomat commented Dec 27, 2021 •

edited

Loading

lukechilds commented Dec 27, 2021

1010Tom commented Dec 28, 2021

lukechilds commented Dec 28, 2021 •

edited

Loading

scratchscratchscratchy commented Dec 29, 2021 •

edited

Loading

klochowicz commented Dec 29, 2021

lukechilds commented Dec 29, 2021

lukechilds commented Dec 29, 2021

lukechilds left a comment

	HiddenServicePort 80 <app-itchysats-ip>:<app-itchysats-port>
	HiddenServicePort 80 <app-itchysats-ip>:8000

	APP_ITCHYSATS_IP="10.21.21.63"
	APP_ITCHYSATS_IP="10.21.21.64"

Add ItchySats App #1149

Add ItchySats App #1149

Conversation

klochowicz commented Dec 7, 2021 • edited Loading

App Submission

App name

Version

One line description of the app

Summary of the app

Developer name

Developer website

Source code link

Support link

Requires

256x256 SVG icon

Gallery images

I have tested my app on:

This comment has been minimized.

aphex3k Dec 11, 2021

Choose a reason for hiding this comment

1010Tom Dec 12, 2021

Choose a reason for hiding this comment

klochowicz commented Dec 13, 2021

lukechilds left a comment • edited Loading

Choose a reason for hiding this comment

lukechilds Dec 23, 2021 • edited Loading

Choose a reason for hiding this comment

1010Tom Dec 24, 2021 • edited Loading

Choose a reason for hiding this comment

lukechilds Dec 23, 2021

Choose a reason for hiding this comment

1010Tom Dec 24, 2021 • edited Loading

Choose a reason for hiding this comment

lukechilds Dec 24, 2021

Choose a reason for hiding this comment

1010Tom Dec 24, 2021

Choose a reason for hiding this comment

lukechilds commented Dec 24, 2021

lukechilds commented Dec 24, 2021

lukechilds commented Dec 24, 2021

lukechilds commented Dec 24, 2021

1010Tom commented Dec 24, 2021

bonomat commented Dec 27, 2021

lukechilds commented Dec 27, 2021

lukechilds commented Dec 27, 2021

bonomat commented Dec 27, 2021

lukechilds commented Dec 27, 2021

lukechilds commented Dec 27, 2021

bonomat commented Dec 27, 2021 • edited Loading

lukechilds commented Dec 27, 2021

1010Tom commented Dec 28, 2021

lukechilds commented Dec 28, 2021 • edited Loading

scratchscratchscratchy commented Dec 29, 2021 • edited Loading

klochowicz commented Dec 29, 2021

lukechilds commented Dec 29, 2021

lukechilds commented Dec 29, 2021

lukechilds left a comment

Choose a reason for hiding this comment

klochowicz commented Dec 7, 2021 •

edited

Loading

lukechilds left a comment •

edited

Loading

lukechilds Dec 23, 2021 •

edited

Loading

1010Tom Dec 24, 2021 •

edited

Loading

1010Tom Dec 24, 2021 •

edited

Loading

bonomat commented Dec 27, 2021 •

edited

Loading

lukechilds commented Dec 28, 2021 •

edited

Loading

scratchscratchscratchy commented Dec 29, 2021 •

edited

Loading