Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Provide seed as argument #978

Closed
1010Tom opened this issue Dec 28, 2021 · 3 comments · Fixed by #1016
Closed

Provide seed as argument #978

1010Tom opened this issue Dec 28, 2021 · 3 comments · Fixed by #1016
Assignees
@rishflab
Milestone
0.4.0 - "Rickroll...

Comments

@1010Tom
Copy link
Collaborator

1010Tom commented Dec 28, 2021 •
edited by thomaseizinger
Loading

Umbrel exposes $APP_SEED which is a hex hex string deterministically derived from the users Umbrel seed. We could make use of this. It would mean that if a user's Umbrel broke and they setup a new one and imported their previous Umbrel seed, the ItchySats app would then derive the same wallet as the previous install and recover the previous funds.

Originally posted by @lukechilds in getumbrel/umbrel#1149 (comment)
@1010Tom 1010Tom mentioned this issue Dec 28, 2021
Merged
6 tasks
@thomaseizinger
Copy link
Contributor

Do we even need #944 then? Seems unnecessary to have two mechanisms for this.

A non-umbrel user can already backup the current seed file and for umbrel, we can make use of APP_SEED. To make this easier to implement, I want to split it into two binaries otherwise we have too much conditional setup logic.

@thomaseizinger thomaseizinger mentioned this issue Dec 28, 2021
Closed
@thomaseizinger
Copy link
Contributor

I've created #984 for this so that this is tracked explicitly.

@thomaseizinger thomaseizinger mentioned this issue Dec 30, 2021
Closed
@bonomat bonomat added this to the 0.4.0 - "Rickrolled Rick" milestone Jan 4, 2022
@bonomat
Copy link
Collaborator

bonomat commented Jan 4, 2022 •
edited
Loading

A few notes:

  • old users need to manually upgrade:
    1. close all positions
    2. withdraw funds
    3. upgrade and deposit funds
  • for this feature we won't need Bip39 Mnemonic + backup and generate mnemonic endpoints #944 anymore because we don't expect users to manage two backups
  • we should implement this onto 0.3.x now and then reimplement it on master

@rishflab rishflab mentioned this issue Jan 4, 2022
Merged
bors bot added a commit that referenced this issue Jan 10, 2022
@bors @rishflab
Merge #1016
95a4962 
1016: Umbrel seed  r=rishflab a=rishflab

Implements #978 for 0.3.x 

Co-authored-by: rishflab <[email protected]>
@thomaseizinger thomaseizinger linked a pull request Jan 11, 2022 that will close this issue
Umbrel seed #1016
Merged
bors bot added a commit that referenced this issue Jan 11, 2022
@bors @rishflab
Merge #1016
ddedfd3 
1016: Umbrel seed  r=rishflab a=rishflab

Implements #978 for 0.3.x 

Co-authored-by: rishflab <[email protected]>
@bors bors bot closed this as completed in #1016 Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rishflab rishflab

Labels
None yet
Projects
None yet
Milestone
0.4.0 - "Rickrolled Rick"
Development

Successfully merging a pull request may close this issue.

Umbrel seed get10101/itchysats
4 participants
@bonomat @thomaseizinger @rishflab @1010Tom