Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Introduce unmangled Name and better DemangleOptions #275

Merged
merged 7 commits into from
Oct 30, 2020
Merged

ref: Introduce unmangled Name and better DemangleOptions #275

merged 7 commits into from
Oct 30, 2020

Conversation

Swatinem
Copy link
Member

DemangleOptions now takes explicit flags with support for arguments and return types.

@Swatinem Swatinem requested a review from a team September 30, 2020 10:11
jan-auer
jan-auer requested changes Oct 1, 2020
View reviewed changes
symbolic-demangle/src/lib.rs Outdated Show resolved Hide resolved
symbolic-demangle/src/lib.rs Show resolved Hide resolved
symbolic-common/src/types.rs Outdated Show resolved Hide resolved
flub
flub approved these changes Oct 1, 2020
View reviewed changes
symbolic-demangle/src/lib.rs Outdated Show resolved Hide resolved
@Swatinem Swatinem force-pushed the ref/demangle-options branch from 0686fb2 to 178df33 Compare October 5, 2020 14:58
@Swatinem
Copy link
Member Author

Swatinem commented Oct 5, 2020

I changed the DemangleOptions to have two constructors now, and the Name to have a tri-state for its mangling. Not quite sure about the naming for that however.

jan-auer
jan-auer reviewed Oct 13, 2020
View reviewed changes
symbolic-common/src/types.rs Outdated Show resolved Hide resolved
symbolic-common/src/types.rs Outdated Show resolved Hide resolved
symbolic-common/src/types.rs Outdated Show resolved Hide resolved
symbolic-demangle/src/lib.rs Outdated Show resolved Hide resolved
symbolic-demangle/src/lib.rs Show resolved Hide resolved
symbolic-demangle/src/lib.rs Outdated Show resolved Hide resolved
@Swatinem Swatinem force-pushed the ref/demangle-options branch from 178df33 to 33177b0 Compare October 13, 2020 11:28
jan-auer
jan-auer reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update BreakpadFunctionIterator to return NameMangling::Unmangled? Breakpad files never contain mangled symbols as per definition.

examples/addr2line/src/main.rs Outdated Show resolved Hide resolved
symbolic-common/src/types.rs Show resolved Hide resolved
symbolic-cabi/src/demangle.rs Outdated Show resolved Hide resolved
symbolic-debuginfo/src/dwarf.rs Outdated Show resolved Hide resolved
@Swatinem Swatinem force-pushed the ref/demangle-options branch from 02b0581 to 5a8ec29 Compare October 19, 2020 13:44
@Swatinem
Copy link
Member Author

talked with jan: rename argument_types to parameters, and merge it ;-)

@Swatinem Swatinem merged commit e31d1bb into master Oct 30, 2020
@Swatinem Swatinem deleted the ref/demangle-options branch October 30, 2020 10:45
jan-auer added a commit that referenced this pull request Nov 17, 2020
@jan-auer
Merge branch 'master' into feature/wasm
bc6b8e5 
* master: (22 commits)
  fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287)
  ci: Use GHA instead of zeus (#286)
  ref: Introduce explicit NameMangling and better DemangleOptions (#275)
  meta: Bump all semver-major dependencies (#283)
  feat(demangle): Update swift demangler to 5.3 (#282)
  ref: Add File/FunctionIterator and lifetimes to DebugSession (#279)
  fix: Implement new clippy advice (#280)
  fix: Add a SymbolIterator and Lifetimes to ObjectLike trait (#277)
  ci: Switch to GitHub Actions (#273)
  ref: Introduce feature flags for demangling languages (#274)
  ref(common): Change InstructionInfo setters to Option (#272)
  ref: Remove all deprecated items (#271)
  ref: Replace failure with std::error::Error (#264)
  ref: Remove deprecated proguard support (#267)
  build: Reorganize the workspace (#266)
  build(unreal): Rename with-serde to serde (#265)
  fix(debuginfo): Detect mangled anonymous namespaces in PDB inlinees (#261)
  release: 7.5.0
  meta: Update changelog for 7.5.0
  feat: Unsafe transmute for PDB symbols (#258)
  ...
jan-auer added a commit that referenced this pull request Dec 22, 2020
@jan-auer
Merge branch 'master' into fix/big-endian-debugid-breakpad
8de7e23 
* master: (21 commits)
  fix: New nightly clippy lint (#295)
  fix(release): Do not publish examples to crates.io
  release: 8.0.0
  ref(debuginfo): Remove re-exports of error types (#300)
  meta: Update changelog
  ref(debuginfo): Switch to error with kind (#299)
  ref(minidump): Switch to error with kind (#298)
  ref(unreal): Switch to error with kind (#297)
  ref(symcache): Switch to error with kind (#296)
  feat: Rename architecture to wasm32 (#294)
  fix(debuginfo): Prefer DWARF names for Dart functions (#293)
  fix: clippy (#292)
  hack(dwarf): Skip line program sequences at 0 (#291)
  feat(wasm): support for wasm (#166)
  ci: Run rust nighlty on a schedule (#289)
  ref: Updates for rust 1.48 (#288)
  fix(debuginfo): Update dmsort to 1.0.1 to avoid panic due to UB (#287)
  ci: Use GHA instead of zeus (#286)
  ref: Introduce explicit NameMangling and better DemangleOptions (#275)
  meta: Bump all semver-major dependencies (#283)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

@flub flub flub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swatinem @flub @jan-auer