feat: Client Metrics #178
Merged
feat: Client Metrics #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 51.29% 52.21% +0.92%
==========================================
Files 29 29
Lines 1431 1444 +13
Branches 107 107
==========================================
+ Hits 734 754 +20
+ Misses 661 654 -7
Partials 36 36 ☔ View full report in Codecov by Sentry. |
| @@ -29,13 +29,6 @@ public async Task StartUploadSymbols(IEnumerable<string> paths, string bundleId, | |||
| SentrySdk.ConfigureScope(s => | |||
| { | |||
| s.Transaction = transaction; | |||
| s.AddEventProcessor(@event => | |||
There was a problem hiding this comment.
Why remove this though? it's helpful to see the summary at the time of the event
bruno-garcia
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could do it the same way metrics got uploaded before but then we would not dogfood the continuous upload of metrics.
TODO
The timing needs work.