Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StartTimer extension method to MetricsAggrigator #3074

Closed
jamescrosswell opened this issue Jan 23, 2024 · 0 comments · Fixed by #3075
Closed

Add StartTimer extension method to MetricsAggrigator #3074

jamescrosswell opened this issue Jan 23, 2024 · 0 comments · Fixed by #3075
Assignees
@jamescrosswell

Comments

@jamescrosswell
Copy link
Collaborator

The API is SentrySdk.Metrics.StartTimer() (or Timing or Timed as you said but that feels awkward to me, is that how .NET'sn new metric API does it? statsd from JustEats calls it StartTimer I believe (it's used in this repo)

Originally posted by @bruno-garcia in getsentry/symbol-collector#178 (comment)
@jamescrosswell jamescrosswell mentioned this issue Jan 23, 2024
Merged
@jamescrosswell jamescrosswell changed the title Add StartTimer extension method to MetricsAggrigator Add Timer extension method to MetricsAggrigator Jan 23, 2024
@jamescrosswell jamescrosswell self-assigned this Jan 23, 2024
@jamescrosswell jamescrosswell mentioned this issue Jan 23, 2024
Merged
@jamescrosswell jamescrosswell changed the title Add Timer extension method to MetricsAggrigator Add StartTimer extension method to MetricsAggrigator Jan 23, 2024
@github-project-automation github-project-automation bot moved this to Done in GDX Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamescrosswell jamescrosswell

Labels
None yet
Projects
GDX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added StartTimer extension method to IMetricAggregator getsentry/sentry-dotnet
1 participant
@jamescrosswell