Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpc-subscriptions): Remove timestamp rounding #6611

Merged

Conversation

shruthilayaj
Copy link
Member

With this change #6609 it's no longer
required to round the timestamps to get back a single time bucket.

Copy link

codecov bot commented Dec 4, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2465 1 2464 5
View the top 1 failed tests by shortest run time
tests.subscriptions.test_data.TestBuildRequest::test_conditions[RPC subscription]
Stack Traces | 0.318s run time
Traceback (most recent call last):
  File ".../tests/subscriptions/test_data.py", line 221, in test_conditions
    self.compare_conditions(subscription, exception, "count", expected_value)
  File ".../tests/subscriptions/test_data.py", line 208, in compare_conditions
    assert result.result["data"][0][aggregate] == value
AssertionError: assert 11.0 == 20.0

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@@ -124,7 +124,7 @@
),
],
),
time_window_secs=3600,
time_window_secs=10800,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BaseSubscriptionTest class that the test inherits from adds events to the previous hour. This test worked before because we were rounding timestamp to the nearest granularity.

The larger time window will catch the events I expect to catch.

Comment on lines +177 to +179
extra_messages = [
gen_span_message(self.base_time - timedelta(hours=4)) for _ in range(2)
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a couple extra messages outside the time bounds of the subscription execution so I know those don't get included in the count

@shruthilayaj shruthilayaj marked this pull request as ready for review December 4, 2024 17:20
@shruthilayaj shruthilayaj requested review from a team as code owners December 4, 2024 17:20
@shruthilayaj shruthilayaj merged commit 4987f3a into master Dec 4, 2024
31 checks passed
@shruthilayaj shruthilayaj deleted the shruthi/chore/remove-timestamp-rounding-rpc-subscriptions branch December 4, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants