-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rpc-subscriptions): Remove timestamp rounding #6611
chore(rpc-subscriptions): Remove timestamp rounding #6611
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
@@ -124,7 +124,7 @@ | |||
), | |||
], | |||
), | |||
time_window_secs=3600, | |||
time_window_secs=10800, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BaseSubscriptionTest
class that the test inherits from adds events to the previous hour. This test worked before because we were rounding timestamp to the nearest granularity.
The larger time window will catch the events I expect to catch.
extra_messages = [ | ||
gen_span_message(self.base_time - timedelta(hours=4)) for _ in range(2) | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a couple extra messages outside the time bounds of the subscription execution so I know those don't get included in the count
With this change #6609 it's no longer
required to round the timestamps to get back a single time bucket.