feat(eap): Rolling time buckets #6609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xurui-c
approved these changes
Dec 3, 2024
shruthilayaj
added a commit
that referenced
this pull request
Dec 4, 2024
With this change #6609 it's no longer required to round the timestamps to get back a single time bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/getsentry/projects/issues/364
Allows bucketing at arbitrary time intervals by taking the difference between the start time and the timestamp as opposed to what the TimeSeriesProcessor did which was
toDateTime(multiply(intDiv(toUInt32(_sort_timestamp), 300), 300), 'Universal')This would always make it land on the clean interval of
09:00, 09:05, 09:10 ...