-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: remove xfail_if_not_postgres #82097
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,6 @@ | |
from sentry.testutils.cases import SnubaTestCase, TestCase, TransactionTestCase | ||
from sentry.testutils.helpers import Feature, apply_feature_flag_on_cls | ||
from sentry.testutils.helpers.datetime import before_now, iso_format | ||
from sentry.testutils.skips import xfail_if_not_postgres | ||
from sentry.types.group import GroupSubStatus, PriorityLevel | ||
from sentry.utils import json | ||
from sentry.utils.snuba import SENTRY_SNUBA_MAP | ||
|
@@ -121,7 +120,7 @@ def setUp(self): | |
data={ | ||
"fingerprint": ["put-me-in-group1"], | ||
"event_id": "a" * 32, | ||
"message": "foo. Also, this message is intended to be greater than 256 characters so that we can put some unique string identifier after that point in the string. The purpose of this is in order to verify we are using snuba to search messages instead of Postgres (postgres truncates at 256 characters and clickhouse does not). santryrox.", | ||
"message": "foo. Indeed, this message is intended to be greater than 256 characters such that we can put this unique string identifier after that point in the string. The purpose of this is in order to verify we are using snuba to search messages instead of Postgres (postgres truncates at 256 characters and clickhouse does not). santryrox.", | ||
"environment": "production", | ||
"tags": {"server": "example.com", "sentry:user": "[email protected]"}, | ||
"timestamp": event1_timestamp, | ||
|
@@ -2120,7 +2119,6 @@ def test_query_enclosed_in_quotes(self): | |
results = self.make_query(search_filter_query='"bar"') | ||
assert set(results) == {self.group2} | ||
|
||
@xfail_if_not_postgres("Wildcard searching only supported in Postgres") | ||
def test_wildcard(self): | ||
escaped_event = self.store_event( | ||
data={ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I subtly adjusted the text here to avoid the wildcards used in the test. most of them used
so*t
which is why all the words modified haveso
in them