ref: remove xfail_if_not_postgres #82097
Merged
+1
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this hasn't been functional since sentry moved to github actions
github-actions
bot
added
the
Scope: Backend
asottile-sentry
commented
Dec 13, 2024
| @@ -121,7 +120,7 @@ def setUp(self): | |||
| data={ | |||
| "fingerprint": ["put-me-in-group1"], | |||
| "event_id": "a" * 32, | |||
| "message": "foo. Also, this message is intended to be greater than 256 characters so that we can put some unique string identifier after that point in the string. The purpose of this is in order to verify we are using snuba to search messages instead of Postgres (postgres truncates at 256 characters and clickhouse does not). santryrox.", | |||
There was a problem hiding this comment.
I subtly adjusted the text here to avoid the wildcards used in the test. most of them used so*t which is why all the words modified have so in them
JoshFerge
approved these changes
Dec 13, 2024
wedamija
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this hasn't been functional since sentry moved to github actions