-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iphone-codes): update BE mapping; remove unused method #82094
Conversation
@armcknight for the frontend you probably want to bump the npm package |
@billyvg I'm having some discussion about that now. It seems that dependency isn't updated any longer: #68258 So I'll just manually update that file. ETA: split that into a different pr: #82100 |
This comment was marked as outdated.
This comment was marked as outdated.
5586bf5
to
c4f9dbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82094 +/- ##
=======================================
Coverage 80.36% 80.37%
=======================================
Files 7275 7275
Lines 321397 321394 -3
Branches 20962 20962
=======================================
+ Hits 258303 258306 +3
+ Misses 62683 62677 -6
Partials 411 411 |
Update the mapping of Apple device hardware IDs to human readable names.
I was going to update https://github.com/getsentry/sentry/blob/master/static/app/constants/ios-device-list.tsx as was last done in #68762 along with this file, but I noticed this warning at the top:
sentry/static/app/constants/ios-device-list.tsx
Lines 1 to 4 in 847b8d6
Question: Should that file have not been edited in that PR? Do we still run that script? If so, we need to put some kind of protection in place so that if the file is manually edited, a precommit hook or PR check flags/disallows it, because it wasn't obvious to me or any other reviewers on that last PR.