-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Apple device mappings #68258
Comments
Routing to @getsentry/product-owners-issues for triage ⏲️ |
related: #68608 |
…ne internal id maps (#68762) Fixes #68608 and #68258 Adds the following devices to both the backend and frontend apple internal device code maps: * iPhone 15 lineup * iPad Air 5th gen * iPad Pro 4th & 6th gen (both sizes) * iPad 10th gen (I used [this repo](https://gist.github.com/adamawolf/3048717) for the device code references) --------- Co-authored-by: Andrew McKnight <[email protected]>
I think we're going to completely remove the profiling file coming up soon https://github.com/getsentry/sentry/blob/e1457f25ce062f8144e2920eac834f54fc48e960/src/sentry/profiles/device.py cc @phacops |
A couple other thoughts:
|
latest device model mapping update #68762 (April 2024) |
@scttcper I'll reopen since we need to do this every year after Apple's hardware refreshes |
I think a good long term goal would be to maintain our own JSON file that can be read by the frontend and backend as needed, so we don't need to maintain two parallel implementations. I took a look at the NPM dependency because I thought we should just fork it, but there's a lot of stuff in there we don't need. We should jettison it. |
We use (at least two) different sources to map Apple device models (e.g.
iPhone15,3
) to device model names (e.g.iPhone 14 Pro Max
) and to resolve device classes (low/med/high) per model:ios-device-list.tsx
iPhone15,3
) to device model names (e.g.iPhone 14 Pro Max
) for the frontendprofilingdevice.py
- deprecated and replaced, see belowthis is updated manuallythis includes both device name mapping and heuristics do determine device class based on hardware specsios_models.py
device_class.rs
iPhone15,3
) to device classes directly, so doesn't rely on device name mappingDocs:
Related:
The text was updated successfully, but these errors were encountered: