Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(similarity): Simplify tests #82031

Merged
merged 13 commits into from
Dec 13, 2024
+67 −433
Merged

tests(similarity): Simplify tests #82031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4e705d7
WIP
armenzg Dec 12, 2024
26b7810
Merge branch 'master' into ref/similarity/backfill/armenzg
armenzg Dec 12, 2024
ee29016
Fix test
armenzg Dec 12, 2024
de603d6
Assert groups
armenzg Dec 12, 2024
fdf92ab
Remove event lookup
armenzg Dec 12, 2024
31f71d4
Remove assert no errors
armenzg Dec 12, 2024
5b72a2b
Merge branch 'master' into ref/similarity/backfill/armenzg
armenzg Dec 12, 2024
f1b0fa3
Use BaseQuerySet
armenzg Dec 12, 2024
7874aca
Revert "Remove assert no errors"
armenzg Dec 12, 2024
4c2839d
Remove mock
armenzg Dec 12, 2024
1e4020f
Update tests
armenzg Dec 12, 2024
2205259
Fix test
armenzg Dec 12, 2024
930c81a
Update tests/sentry/tasks/test_backfill_seer_grouping_records.py
armenzg Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/sentry/tasks/embeddings_grouping/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from sentry.eventstore.models import Event
from sentry.grouping.grouping_info import get_grouping_info
from sentry.issues.grouptype import ErrorGroupType
from sentry.issues.occurrence_consumer import EventLookupError
from sentry.models.group import Group, GroupStatus
from sentry.models.project import Project
from sentry.seer.similarity.grouping_records import (
Expand Down Expand Up @@ -682,16 +681,6 @@ def _retry_operation(operation, *args, retries, delay, exceptions, **kwargs):
raise


# TODO: delete this and its tests
def lookup_event(project_id: int, event_id: str, group_id: int) -> Event:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in use.

data = nodestore.backend.get(Event.generate_node_id(project_id, event_id))
if data is None:
raise EventLookupError(f"Failed to lookup event({event_id}) for project_id({project_id})")
event = Event(event_id=event_id, project_id=project_id, group_id=group_id)
event.data = data
return event


def delete_seer_grouping_records(
project_id: int,
):
Expand Down
Loading
Loading