tests(similarity): Simplify tests #82031
Merged
+67
−433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 31f71d4.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Dec 12, 2024
| @@ -682,16 +681,6 @@ def _retry_operation(operation, *args, retries, delay, exceptions, **kwargs): | |||
| raise | |||
|
|
|||
|
|
|||
| # TODO: delete this and its tests | |||
| def lookup_event(project_id: int, event_id: str, group_id: int) -> Event: | |||
| bulk_data["rows"], | ||
| bulk_data["events"], | ||
| ) | ||
| self.event = self.store_event( |
There was a problem hiding this comment.
This gets replaced by self.event = bulk_data["events"][0].
| self.event.group.times_seen = 5 | ||
| self.event.group.save() | ||
|
|
||
| self.wait_for_event_count(self.project.id, 6) |
There was a problem hiding this comment.
This is not necessary and it speeds up a tiny bit the execution of the tests.
| "similarity_model_version": SEER_SIMILARITY_MODEL_VERSION, | ||
| "request_hash": self.group_hashes[group.id], | ||
| } | ||
| self.assert_groups_metadata_updated(groups) |
There was a problem hiding this comment.
Testing the final state rather than the output of the logger.
| @@ -1199,13 +882,13 @@ def test_backfill_seer_grouping_records_multiple_batches( | |||
| "backfill_seer_grouping_records.batch", | |||
| extra={ | |||
| "project_id": self.project.id, | |||
| "batch_len": 6, | |||
| "batch_len": 5, | |||
There was a problem hiding this comment.
This changes because in the set up we don't create an extra event.
| @@ -1268,15 +951,14 @@ def test_backfill_seer_grouping_records_only_delete(self, mock_project_delete_gr | |||
| assert group.data["metadata"] == default_metadata | |||
|
|
|||
| @patch("sentry.tasks.embeddings_grouping.utils.delete_project_grouping_records") | |||
| @patch("sentry.tasks.embeddings_grouping.backfill_seer_grouping_records_for_project.logger") | |||
| @patch("sentry.tasks.embeddings_grouping.utils.post_bulk_grouping_records") | |||
There was a problem hiding this comment.
We're going to call the task first to populate the metadata.
wedamija
approved these changes
Dec 12, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of the assertion for mocked logs.