feat(replay): Use SDK value for LCP #44868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes LCP breadcrumb rendering to use `data.value` instead of trying to calculate the value (which ends up resulting in incorrect values as it uses the replay start timestamp, so LCP from a refresh will be wrong). Related getsentry/sentry-javascript#7225
github-actions
bot
added
the
Scope: Frontend
size-limit report 📦
|
billyvg
commented
Feb 21, 2023
Comment on lines
10
to
11
| if (crumb.data?.value !== undefined) { | ||
| return `${crumb.data.value}ms`; |
There was a problem hiding this comment.
This means replays with older SDKs will not have any value, but only the first LCP value would be accurate. Wonder if we stick a SDK upgrade CTA here 😄
There was a problem hiding this comment.
nothing is better than something which is wrong imo.
if we're doing a cta to upgrade the sdk we should be looking at the most recent replay and it's version, because they might've just updated and this a replay from last week that's being viewed
There was a problem hiding this comment.
Good point re: most recent replay -- I think we'll make the CTA just a tooltip so it's less intrusive and keep it simple by looking at the replay's version.
ryan953
approved these changes
Feb 22, 2023
billyvg
commented
Feb 24, 2023
| if (crumb.timestamp && startTimestampMs) { | ||
| return `${new Date(crumb.timestamp).getTime() - startTimestampMs}ms`; | ||
| if (crumb.data?.value !== undefined) { | ||
| return `${Math.round(crumb.data.value)}ms`; |
Comment on lines
+16
to
+27
| if (crumb.data?.duration !== undefined) { | ||
| // this means user is using an old SDK where LCP values are not | ||
| // always correct. Prompt them to upgrade | ||
| return ( | ||
| <Tooltip | ||
| title={t( | ||
| 'This replay uses a SDK version that is subject to inaccurate LCP values. Please upgrade to the latest version for best results if you have not already done so.' | ||
| )} | ||
| > | ||
| <IconWarning /> | ||
| </Tooltip> | ||
| ); |
There was a problem hiding this comment.
This is new since last PR -- ss in PR desc.
| @@ -74,7 +75,9 @@ function BreadcrumbItem({ | |||
| ) : null} | |||
| </TitleContainer> | |||
|
|
|||
| <Description title={description}>{description}</Description> | |||
| <Tooltip title={description} showOnlyOnOverflow> | |||
There was a problem hiding this comment.
Previously it was expecting a string, now it uses <Tooltip> so that we can also hide the native tooltip when it is not overflowing.
jan-auer
added a commit
that referenced
this pull request
Mar 1, 2023
* master: (37 commits) ref(ppf): Don't use --commit-batch-size for futures queue length (#45182) feat(codecov-v2): Add more logging (#45225) fix(alerts): Center table items on alert history page (#45226) feat(CapMan): Pass `tenant_ids` to Snuba (#44788) ref(db): Drop `project_id` from Environment (model state) (#45207) chore(profiling): Rename context in profiles task (#45208) feat(replays): Improve index page query performance (#45098) chore(issue assignment): Add logging for`GroupOwner` auto assignment (#45142) fix(hybrid-cloud): Uncache organization when queueing it for deletion (#45213) fix(perf): Navigating to Transaction Summary from Trends widget should persist custom date selection (#45190) fix(pageFilter): Fix overflow (#45169) ref(git hooks): Only suggest autoupdate variable when pulling if not already set (#45179) fix(dashboard): Include dashboard filters in widget viewer (#45106) fix(alerts): Remove null projects from alerts list (#45202) feat(replay): Update Inline replay onboarding img to support dark mode (#45084) __iexact reduce call has default value now. (#45206) feat(replay): Use SDK value for LCP (#44868) chore(hybrid-cloud): breaking foreign keys (#45203) Revert "ref(db): Drop `project_id` from Environment (model state) (#45094)" ref(db): Drop `project_id` from Environment (model state) (#45094) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes LCP breadcrumb rendering to use
data.valueinstead of trying to calculate the value (which ends up resulting in incorrect values as it uses the replay start timestamp, so LCP from a refresh will be wrong).Related getsentry/sentry-javascript#7225
Note that the above PR changes start + end timestamps to be equal since LCP is a single point in time rather than a range. The above PR also corrects the timestamp to be when the LCP occurs (rather than the previous start timestamp which is wrong and generally ends up around page load time).
Adds a warning for old SDK versions:
