Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCP is wrong when it's after a Reload #39128

Closed
billyvg opened this issue Sep 21, 2022 · 2 comments
Closed

LCP is wrong when it's after a Reload #39128

billyvg opened this issue Sep 21, 2022 · 2 comments

Comments

@billyvg
Copy link
Member

billyvg commented Sep 21, 2022 •
edited
Loading

Note: this would be better off handled in the SDK

We can have multiple sets of LCPs in a replay due to page reloads. This means that the LCP duration will be wrong because it is always relative to the starting timestamp of the replay instead of the timestamp of the most recent "navigation" event.
@billyvg
Copy link
Member Author

billyvg commented Dec 5, 2022

Related getsentry/sentry-replay#305

@billyvg
Copy link
Member Author

billyvg commented Mar 6, 2023

Closed by #44868

@billyvg billyvg closed this as completed Mar 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billyvg @bruno-garcia