feat(ci): Python deps to install specific packages #28901
Conversation
|
@untitaker fyi |
| @@ -28,9 +28,11 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
|
|
|||
| - name: Install prerequisites | |||
| # brew can be finicky but it does not always means that the rest of the job will fail | |||
| env: | |||
| HOMEBREW_NO_AUTO_UPDATE: on | |||
There was a problem hiding this comment.
The python-deps workflow is not intended to test against user's dev env setup right?
There was a problem hiding this comment.
No. We're using brew because it's available and Mac and Linux.
No auto update with just brew install is to make it execute faster.
If we had kept make prerequisites which calls brew bundle, it might have saved updating to some new library that breaks as we see on CI
From the man page:
HOMEBREW_NO_AUTO_UPDATE
If set, do not automatically update before running some commands e.g. brew install, brew upgrade and brew tap.
| make prerequisites | ||
| brew install libxmlsec1 |
There was a problem hiding this comment.
Why not run make prerequisites?
There was a problem hiding this comment.
brew bundle includes a lot of packages that could suddenly be upgraded and start failing.
Reducing it to libxmlsec1 reduces it to only one package.
I want the python-deps to fail the least to avoid engineers be confused.
It is also almost what we used to do before make prerequisites 3f71db8#diff-9bec90e4ad9a179ec1c8e1266c2ddc2fc0fbd73db55720b3425cfdf667b89e14
|
I marked as this being related to Apple M1 work because this is the fallout from work in #28607 |
This reduces the number of packages that get installed by brew and it prevents upgrading packages.
This reduces the number of packages that get installed by
brewand it prevents upgrading packages.