feat(dev): Install postgresql on Apple M1 to build psycopg2-binary #28607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new target which installs different libraries via brew depending on the context. For instance, on Apple M1 machines it should installed a couple more libraries. In the future, the bootstrap script and documentation should be using this target. Fixes #28606
armenzg
added
the
Component: Developer Environment
armenzg
changed the title
armenzg
commented
Sep 21, 2021
requirements-base.txt
Outdated
| psycopg2-binary==2.8.6 | ||
| psycopg2-binary==2.8.6; python_version == '3.6' | ||
| # This removes needing to set CPPFLAGS & LDFLAGS | ||
| psycopg2-binary==2.9.1; python_version > '3.8' |
There was a problem hiding this comment.
If I don't do this, I would have to do this somewhere in install-py-dev:
CPPFLAGS="-I/opt/homebrew/opt/[email protected]/include" \
LDFLAGS="-L/opt/homebrew/opt/[email protected]/lib -L/opt/homebrew/opt/[email protected]/lib" \
pip install psycopg2-binary==2.8.6
There was a problem hiding this comment.
You won't be installing this on 3.8.
Ignoring psycopg2-binary: markers 'python_version == "3.6"' don't match your environment
Ignoring psycopg2-binary: markers 'python_version > "3.8"' don't match your environment
There was a problem hiding this comment.
Good catch! It was a last second commit that introduced the problem. I've corrected this and tested it out.
billyvg
reviewed
Sep 22, 2021
| @@ -24,7 +24,7 @@ jobs: | |||
| fail-fast: false | |||
| env: | |||
| PIP_DISABLE_PIP_VERSION_CHECK: on | |||
| # Make the environment more similar to what Mac defaults to | |||
| # Make the environment more similar to hat Mac defaults to | |||
requirements-base.txt
Outdated
| @@ -35,7 +35,9 @@ Pillow==8.2.0; python_version == '3.6' | |||
| Pillow==8.3.1; python_version > '3.6' | |||
| progressbar2==3.32.0 | |||
| python-rapidjson==1.4 | |||
| psycopg2-binary==2.8.6 | |||
| psycopg2-binary==2.8.6; python_version == '3.6' | |||
| # This removes needing to set CPPFLAGS & LDFLAGS | |||
There was a problem hiding this comment.
Should we note that this only affects local development since we only support 3.6 in prod atm?
billyvg
approved these changes
Sep 22, 2021
joshuarli
approved these changes
Sep 22, 2021
armenzg
changed the title
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
…28607) Create a new target which installs different libraries via brew depending on the context. For instance, on Apple M1 machines it should installed a couple more libraries. This helps to install the psycopg2-binary package since there's no wheel for it. We also upgrade the version of it in order to avoid needing to set some CPPFLAGS & LDFLAGS. In the future, the bootstrap script and documentation should be using this target. Fixes #28606
armenzg
added a commit
that referenced
this pull request
Oct 1, 2021
For the incompatibility issue with Django visit [this issue][incompatible], In this PR, we're going to downgrade to the compatible 2.8.6 version (thus, matching the Python 3.6 version), removing the need to install `postgresql` (this means partially reverting #28607) and instead installing a wheel I built on my machine that I have stored in GC storage. Fixes #28958 [incompatible]: psycopg/psycopg2#1293
armenzg
added a commit
that referenced
this pull request
Oct 6, 2021
For the incompatibility issue with Django visit [this issue][incompatible], In this PR, we're going to downgrade to the compatible 2.8.6 version (thus, matching the Python 3.6 version), removing the need to install `postgresql` (this means partially reverting #28607) and instead installing a wheel I built on my machine that I have stored in GC storage. Fixes #28958 [incompatible]: psycopg/psycopg2#1293
armenzg
added a commit
that referenced
this pull request
Oct 7, 2021
For the incompatibility issue with Django visit [this issue][incompatible], In this PR, we're going to downgrade to the compatible 2.8.6 version (thus, matching the Python 3.6 version), removing the need to install `postgresql` (this means partially reverting #28607) and instead installing a wheel I built on my machine that I have stored in GC storage. Fixes #28958 [incompatible]: psycopg/psycopg2#1293
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new target which installs different libraries via brew depending on the context.
For instance, on Apple M1 machines it should installed a couple more libraries.
In the future, the bootstrap script and documentation should be using this target.
Fixes #28606