feature(ios): Add processor count to device info #2984

krystofwoldrich · 2023-04-19T14:45:23Z

📢 Type of change

New feature

📜 Description

Add CPU count from iOS. Android works already since the version it was added to sentry-java no changes in RN are needed.

💡 Motivation and Context

closes: Extend Device Context with CPU info #2884

💚 How did you test it?

sample app

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2023-04-19T14:46:29Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c523007

github-actions · 2023-04-19T15:16:25Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1234.82 ms	1247.86 ms	13.04 ms
Size	2.36 MiB	2.84 MiB	489.60 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms
`ad6c299`+dirty	1244.76 ms	1260.10 ms	15.34 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`0db0c72`+dirty	1275.02 ms	1285.84 ms	10.82 ms

App size

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB
`ad6c299`+dirty	2.36 MiB	2.84 MiB	488.85 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`0db0c72`+dirty	2.36 MiB	2.84 MiB	487.01 KiB

github-actions · 2023-04-19T15:41:44Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	292.15 ms	364.47 ms	72.32 ms
Size	7.15 MiB	8.04 MiB	912.17 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms
`ad6c299`+dirty	336.47 ms	362.89 ms	26.42 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`d7401ac`+dirty	373.98 ms	394.08 ms	20.10 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`80b2ce3`+dirty	271.29 ms	316.47 ms	45.18 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`0db0c72`+dirty	335.20 ms	351.06 ms	15.86 ms

App size

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB
`ad6c299`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`d7401ac`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`80b2ce3`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`0db0c72`+dirty	7.15 MiB	8.04 MiB	911.02 KiB

github-actions · 2023-04-20T10:22:50Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	392.10 ms	400.66 ms	8.56 ms
Size	17.73 MiB	19.75 MiB	2.02 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`d7401ac`+dirty	375.20 ms	383.51 ms	8.31 ms
`80b2ce3`	385.02 ms	387.36 ms	2.34 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`ad6c299`	375.94 ms	382.02 ms	6.08 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms

App size

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d7401ac`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`80b2ce3`	17.73 MiB	19.75 MiB	2.02 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`ad6c299`	17.73 MiB	19.75 MiB	2.02 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

github-actions · 2023-04-20T11:58:06Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1256.08 ms	1271.48 ms	15.40 ms
Size	2.92 MiB	3.40 MiB	494.23 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`0db0c72`+dirty	1258.88 ms	1262.52 ms	3.64 ms
`dadc233`+dirty	1266.52 ms	1282.55 ms	16.03 ms

App size

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`0db0c72`+dirty	2.92 MiB	3.40 MiB	492.71 KiB
`dadc233`+dirty	2.92 MiB	3.40 MiB	492.53 KiB

ios/RNSentry.mm

krystofwoldrich added 3 commits April 3, 2023 16:22

feature(ios): Add processor count to device info

187180a

Merge remote-tracking branch 'origin/main' into kw-add-cpu-info

7fa7699

Merge branch 'main' into kw-add-cpu-info

6d41cf3

krystofwoldrich requested a review from marandaneto as a code owner April 19, 2023 14:45

krystofwoldrich marked this pull request as draft April 19, 2023 14:45

krystofwoldrich added 2 commits April 20, 2023 11:48

Merge remote-tracking branch 'origin/main' into kw-add-cpu-info

3ec3d4b

Update changelog

a1d8e85

krystofwoldrich marked this pull request as ready for review April 20, 2023 10:01

marandaneto reviewed Apr 21, 2023

View reviewed changes

ios/RNSentry.mm Show resolved Hide resolved

marandaneto reviewed Apr 21, 2023

View reviewed changes

ios/RNSentry.mm Outdated Show resolved Hide resolved

krystofwoldrich mentioned this pull request Apr 21, 2023

Use getExtraContext on iOS getsentry/sentry-dart#1401

Closed

krystofwoldrich added 2 commits April 21, 2023 16:57

Merge remote-tracking branch 'origin/main' into kw-add-cpu-info

b0b8b5f

check if extra context data are valid

19e40aa

krystofwoldrich requested a review from marandaneto April 24, 2023 10:40

marandaneto approved these changes Apr 24, 2023

View reviewed changes

Merge branch 'main' into kw-add-cpu-info

c523007

krystofwoldrich enabled auto-merge (squash) April 24, 2023 16:56

krystofwoldrich merged commit 437ade1 into main Apr 24, 2023

krystofwoldrich deleted the kw-add-cpu-info branch April 24, 2023 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(ios): Add processor count to device info #2984

feature(ios): Add processor count to device info #2984

krystofwoldrich commented Apr 19, 2023

github-actions bot commented Apr 19, 2023 •

edited

Loading

github-actions bot commented Apr 19, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 19, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 20, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 20, 2023

Baseline results on branch: main

Startup times

App size

feature(ios): Add processor count to device info #2984

feature(ios): Add processor count to device info #2984

Conversation

krystofwoldrich commented Apr 19, 2023

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Apr 19, 2023 • edited Loading

github-actions bot commented Apr 19, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 19, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 20, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 20, 2023

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 19, 2023 •

edited

Loading

github-actions bot commented Apr 19, 2023 •

edited

Loading

github-actions bot commented Apr 19, 2023 •

edited

Loading

github-actions bot commented Apr 20, 2023 •

edited

Loading