Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Device Context with CPU info #2884

Closed
Tracked by #77
kahest opened this issue Mar 10, 2023 · 5 comments · Fixed by #2984
Closed
Tracked by #77

Extend Device Context with CPU info #2884

kahest opened this issue Mar 10, 2023 · 5 comments · Fixed by #2984

Comments

@kahest
Copy link
Member

kahest commented Mar 10, 2023

Our device context docs describe a few new CPU related fields which are not provided by the mobile SDKs yet.

  • processor_count
  • cpu_description
  • processor_frequency

Need to write the native parts to get the data (or reproduce from getsentry/sentry-java#2561 and getsentry/sentry-cocoa#2740).

@kahest kahest transferred this issue from getsentry/team-mobile Mar 10, 2023
@kahest kahest changed the title React Native Extend Device Context with CPU info Mar 10, 2023
@kahest kahest moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 10, 2023
@krystofwoldrich
Copy link
Member

Types are already present in JS SDK so RN can use them right away.

@krystofwoldrich
Copy link
Member

@philipphofmann @brustolin Is there a sentry-cocoa release coming soon so we can unblock this?

@krystofwoldrich krystofwoldrich moved this from Needs Review to Blocked in Mobile & Cross Platform SDK Apr 12, 2023
@philipphofmann
Copy link
Member

@brustolin, the getsentry/sentry-cocoa#2855 was not released yet. I think CI should be stable enough again after merging getsentry/sentry-cocoa#2889.

@brustolin
Copy link
Contributor

@philipphofmann Yes, I was thinking about the wrong PR, but I guess we can try to make a new release now.

@philipphofmann
Copy link
Member

I think we should still wait for getsentry/sentry-cocoa#2879 and getsentry/sentry-cocoa#2891, but then yes, let's release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants