-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hybrid): Move extra context to standalone class #2855
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fb7afb | 1202.18 ms | 1219.42 ms | 17.24 ms |
9e96fd6 | 1207.20 ms | 1229.40 ms | 22.20 ms |
984eb2d | 1220.62 ms | 1235.24 ms | 14.62 ms |
d60f70a | 1219.63 ms | 1228.54 ms | 8.91 ms |
e8b2fb4 | 1230.70 ms | 1242.84 ms | 12.14 ms |
28333b6 | 1186.29 ms | 1225.18 ms | 38.89 ms |
25bcc50 | 1237.69 ms | 1258.40 ms | 20.71 ms |
3389927 | 1230.12 ms | 1238.04 ms | 7.92 ms |
ddc9b9a | 1210.00 ms | 1234.18 ms | 24.18 ms |
67460f4 | 1244.56 ms | 1255.96 ms | 11.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
9e96fd6 | 20.76 KiB | 425.80 KiB | 405.04 KiB |
984eb2d | 20.76 KiB | 425.77 KiB | 405.01 KiB |
d60f70a | 20.76 KiB | 430.97 KiB | 410.21 KiB |
e8b2fb4 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
28333b6 | 20.76 KiB | 424.69 KiB | 403.93 KiB |
25bcc50 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
3389927 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
ddc9b9a | 20.76 KiB | 420.40 KiB | 399.64 KiB |
67460f4 | 20.76 KiB | 426.15 KiB | 405.39 KiB |
Previous results on branch: kw-refactor-extra-context
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
83ddda5 | 1227.18 ms | 1238.62 ms | 11.44 ms |
2a3e27e | 1216.35 ms | 1238.28 ms | 21.93 ms |
b7a2220 | 1252.66 ms | 1256.64 ms | 3.98 ms |
a981aa9 | 1241.92 ms | 1254.47 ms | 12.55 ms |
b48675b | 1190.02 ms | 1217.49 ms | 27.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
83ddda5 | 20.76 KiB | 431.93 KiB | 411.17 KiB |
2a3e27e | 20.76 KiB | 431.90 KiB | 411.14 KiB |
b7a2220 | 20.76 KiB | 431.99 KiB | 411.23 KiB |
a981aa9 | 20.76 KiB | 431.96 KiB | 411.20 KiB |
b48675b | 20.76 KiB | 431.93 KiB | 411.17 KiB |
Co-authored-by: Dhiogo Brustolin <[email protected]>
Co-authored-by: Dhiogo Brustolin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First full look.
Some minor suggestions to make code cleaner.
And I think, instead of providing extraContextProvider to SentryClient, you should make SentryContextProvider
init to ask for crashWrapper
, deviceWrapper
and ProcessInfoWrapper
, then you initialize a SentryContextProvider inside SentryClient.
This way you fix CI
@brustolin Thank you for the suggestions and help with the tests. I've added tests for the provider and fixed the client tests. I hope the CI will be happy this time. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
==========================================
+ Coverage 79.90% 81.45% +1.54%
==========================================
Files 259 261 +2
Lines 24362 24425 +63
Branches 10475 10824 +349
==========================================
+ Hits 19467 19895 +428
+ Misses 4386 4027 -359
+ Partials 509 503 -6
... and 77 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
This enables us to reuse the same extra context logic in hybrid SDKs.
💡 Motivation and Context
💚 How did you test it?
cocoa sample app and rn sample app
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps
#skip-changelog