Use is_iterable instead of is_array #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you think that this change deserve it's existence I can add tests |
|
Yes please, once the tests are in place I will gladly merge the PR |
|
@ste93cry I just committed the test 👍 |
alexgt9
force-pushed
the
patch-1
branch
2 times, most recently
from
fa23cf4 to
12b67c8
Compare
|
Instead of merging, can you please rebase on top of |
|
Sure, I just did it, I didn't know you were using develop |
ste93cry
suggested changes
Mar 23, 2020
ste93cry
approved these changes
Mar 23, 2020
Jean85
suggested changes
Mar 24, 2020
alexgt9
force-pushed
the
patch-1
branch
2 times, most recently
from
8abdff8 to
43f1c48
Compare
Ouch!, added. |
Jean85
approved these changes
Mar 24, 2020
|
I'm sorry but this seems to break Behat, please see #1028 |
ste93cry
pushed a commit
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What about using
is_iterableto allow Traversable objects to be processed automatically?If the check is only to be able to do a foreach, I think it's safe.