Use is_iterable instead of is_array

getsentry · Mar 23, 2020 · 399e98a · 399e98a
1 parent 4bb4e54
commit 399e98a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Serializer/AbstractSerializer.php b/src/Serializer/AbstractSerializer.php
@@ -103,7 +103,7 @@ protected function serializeRecursively($value, int $_depth = 0)
                 return $this->serializeCallableWithoutTypeHint($value);
             }
 
-            if (\is_array($value)) {
+            if (is_iterable($value)) {
                 $serializedArray = [];
 
                 foreach ($value as $k => $v) {

diff --git a/tests/Serializer/SerializerTest.php b/tests/Serializer/SerializerTest.php
@@ -27,6 +27,24 @@ public function testArraysAreArrays(bool $serializeAllObjects): void
         $this->assertSame([1, 2, 3], $result);
     }
 
+    /**
+     * @dataProvider serializeAllObjectsDataProvider
+     */
+    public function testTraversablesAreArrays(bool $serializeAllObjects): void
+    {
+        $serializer = $this->createSerializer();
+
+        if ($serializeAllObjects) {
+            $serializer->setSerializeAllObjects(true);
+        }
+
+        $content = [1, 2, 3];
+        $traversable = new \ArrayIterator($content);
+        $result = $this->invokeSerialization($serializer, $traversable);
+
+        $this->assertSame([1, 2, 3], $result);
+    }
+
     /**
      * @dataProvider serializeAllObjectsDataProvider
      */