Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated event.stacktrace #4885

Merged
merged 18 commits into from
Apr 11, 2022
Merged

Remove usage of deprecated event.stacktrace #4885

merged 18 commits into from
Apr 11, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 7, 2022 •
edited by AbhiPrasad
Loading

Removes usage of deprecated event.stacktrace

I'll add some inline comments to cover my remaining concerns...

Fixes #2605

AbhiPrasad and others added 12 commits April 7, 2022 13:32
@AbhiPrasad @Lms24
[v7] feat: Remove references to @sentry/apm (getsentry#4845)
97e6ff3 
Removes all references to `@sentry/apm`, a deprecated package we do not use anymore.
@AbhiPrasad @Lms24
[v7] feat(core): Delete API class (getsentry#4848)
57d37c2 
Removes the deprecated `API` class.
@AbhiPrasad @Lms24
[v7] feat: Delete deprecated startSpan and child methods (getsent…
424df27 
…ry#4849)

Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
@AbhiPrasad @Lms24
feat(core): Remove whitelistUrls/blacklistUrls (getsentry#4850)
5a7f145
@AbhiPrasad @Lms24
feat(gatsby): Remove Sentry from window (getsentry#4857)
f855260
@AbhiPrasad @Lms24
feat(hub): Remove getActiveDomain (getsentry#4858)
f1e9da2 
Removes `getActiveDomain` function and corresponding type.
@AbhiPrasad @Lms24
feat(types): Remove deprecated user dsn field (getsentry#4864)
55b0570 
The `user` dsn component was renamed to `publicKey`. This PR removes that from the dsn field.
@AbhiPrasad @Lms24
feat(hub): Remove setTransaction scope method (getsentry#4865)
2fc13c6
@AbhiPrasad @Lms24
[v7] feat: Drop support for Node 6 (getsentry#4851)
20c7773
@AbhiPrasad @Lms24
[v7] feat(tracing): Rename registerRequestInstrumentation -> instrume…
244eb0e 
…ntOutgoingRequests (getsentry#4859)
@Lms24
fix(test): Increase MongoMemoryServer creation timeout (getsentry#4881)
285ca26 
Increases the creation timeout of `MongoMemoryServer` to temporarily fix Node integration test flakiness
@timfish
Removes usage of deprecated event.stacktrace
8afb70c
@timfish timfish mentioned this pull request Apr 7, 2022
Closed
15 tasks
AbhiPrasad
AbhiPrasad previously approved these changes Apr 7, 2022
View reviewed changes
@AbhiPrasad AbhiPrasad dismissed their stale review April 7, 2022 16:19

test + lint

@timfish timfish force-pushed the v7/remove-deprecated-event.stacktrace branch from 1131a9f to 04c3602 Compare April 7, 2022 16:25
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 7, 2022
@timfish timfish force-pushed the v7/remove-deprecated-event.stacktrace branch from 04c3602 to 6865b6e Compare April 7, 2022 16:59
@timfish
Copy link
Collaborator Author

timfish commented Apr 7, 2022 •
edited
Loading

This broke a lot more tests than I imagined it would. Is this because event.stacktrace was initially the default?

Does this mean this change likely to be high impact to customers?

@AbhiPrasad
Copy link
Member

This actually broke a lot more tests than I imagined it would. Is this because event.stacktrace was initially the default?

Does this mean this change likely to be high impact to customers?

This is a good observation. I realized that most folks might have to make significant updates to beforeSend as a result. Putting this on the list to chat with the rest of the team - I’ll get back to you by tommorow.

@lobsterkatie lobsterkatie changed the title [v7] Remove usage of deprecated event.stacktrace Remove usage of deprecated event.stacktrace Apr 7, 2022
@lobsterkatie
Copy link
Member

@timfish FYI, now that we're on the v7 branch, we don't need to prefix PRs with [v7] anymore. 🎉

@AbhiPrasad
Copy link
Member

Mind if you can rebase this? The diff is a little hard to read.

We chatted as a team, and we think it's fine for us to move off of event.stacktrace - let's go ahead with these changes!

@timfish
Copy link
Collaborator Author

timfish commented Apr 11, 2022

Rebased. Is the Ember failure a flake?

@AbhiPrasad
Copy link
Member

Yup - ember is a flake.

@AbhiPrasad AbhiPrasad merged commit 2ecf1e5 into getsentry:7.x Apr 11, 2022
lobsterkatie pushed a commit that referenced this pull request Apr 13, 2022
@timfish @lobsterkatie
feat: Remove usage of deprecated event.stacktrace (#4885)
744252a 
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@timfish @Lms24
feat: Remove usage of deprecated event.stacktrace (#4885)
c6f5cc0 
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@timfish @lobsterkatie
ref(various): Remove usage of deprecated event.stacktrace (#4885)
56b855b 
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@timfish @lobsterkatie
ref(various): Remove usage of deprecated event.stacktrace (#4885)
07d4ffd 
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.
@timfish timfish deleted the v7/remove-deprecated-event.stacktrace branch May 19, 2022 13:14
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@timfish @AbhiPrasad
ref(various): Remove usage of deprecated event.stacktrace (#4885)
99498dc 
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.
@plibither8 plibither8 mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timfish @AbhiPrasad @lobsterkatie @Lms24