Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] feat(core): Delete API class #4848

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[v7] feat(core): Delete API class #4848

merged 2 commits into from
Apr 7, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Apr 4, 2022 •
edited
Loading

Removes the deprecated API class.

See: #4281

Resolves https://getsentry.atlassian.net/browse/WEB-549

@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 4, 2022
@AbhiPrasad AbhiPrasad force-pushed the v7-abhi-api-delete branch from 7959672 to 3845861 Compare April 4, 2022 17:30
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.21 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 65.26 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.89 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.27 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 23.1 KB (-0.55% 🔽)
@sentry/browser - Webpack (minified) 81.63 KB (-0.67% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.14 KB (-0.55% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.89 KB (-0.3% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.15 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.5 KB (0%)

@AbhiPrasad AbhiPrasad force-pushed the v7-abhi-api-delete branch from 3845861 to d4089ed Compare April 4, 2022 20:38
lforst
lforst approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is a bit iffy now but lgtm otherwise

packages/core/test/lib/api.test.ts Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad changed the base branch from master to 7.x April 7, 2022 01:12
@AbhiPrasad AbhiPrasad marked this pull request as ready for review April 7, 2022 01:12
@AbhiPrasad AbhiPrasad merged commit 5487dbb into 7.x Apr 7, 2022
@AbhiPrasad AbhiPrasad deleted the v7-abhi-api-delete branch April 7, 2022 01:12
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @Lms24
[v7] feat(core): Delete API class (#4848)
e277e40 
Removes the deprecated `API` class.
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @Lms24
[v7] feat(core): Delete API class (#4848)
57d37c2 
Removes the deprecated `API` class.
lobsterkatie pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @lobsterkatie
[v7] feat(core): Delete API class (#4848)
7e50a94 
Removes the deprecated `API` class.
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @Lms24
[v7] feat(core): Delete API class (#4848)
d79582d 
Removes the deprecated `API` class.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref(core): Delete API class (#4848)
f501391 
Removes the deprecated `API` class.
AbhiPrasad added a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref(core): Delete API class (#4848)
47fb065 
Removes the deprecated `API` class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lforst