-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 8.33.0 #13852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements getsentry/size-limit-release#6 This is now working again: https://github.com/getsentry/sentry-javascript/actions/runs/11031636865
Based on customer feedback.
Update Bug Report template to clarify that the event URL is public
The `buildDir` can be changed in Nuxt and Adding the client config with a relative path worked so far as the `buildDir` in Nuxt v3 is [`/<rootDir>/.nuxt`](https://nuxt.com/docs/api/nuxt-config#builddir) but the `buildDir` can be modified by the user and is also different in Nuxt v4 ([`/<rootDir>/node_modules/.cache/nuxt/.nuxt`](https://github.com/nuxt/nuxt/blob/f56c05d39de5223c5fa8603ed216e91747937d54/packages/kit/src/loader/config.ts#L54)). By using the absolute path, the client config can be injected correctly with all `buildDir` variations
Source maps generated by Vite are only for the Nuxt-part of the application whereas source maps generated by Rollup are only for the Nitro-part of the application. The Nuxt-part of the application has some overlap with the Nitro-part and so it **would** be nice to specify the client/server folder in the `assets` option, but the output is different for every Nitro preset (the files are always located under a different path). Should fix #13703
This ensures that whenever we publish a release, we automatically add a comment to all issues linked to PRs like this: #13312 (comment) ![image](https://github.com/user-attachments/assets/c84a810f-5653-4fcc-85d0-bc6ad0aa4801) This way, we do not need to manually go through issues, but users can automatically be notified that a change should be out now.
Test for pageload. Tests for distributed tracing for navigations are still coming (waiting for next Nuxt version which includes the new version of ofetch with [this PR](unjs/ofetch#377))
Resolves: #13309 Adds integration for `lru-memoizer` using [@opentelemetry/instrumentation-lru-memoizer](https://www.npmjs.com/package/@opentelemetry/instrumentation-lru-memoizer). This instrumentation does not create any spans. It only assigns the span context into memoized callbacks used in `lru-memoizer`'s `load`. Ported a test case from the original implementation and tested manually to validate.
[Gitflow] Merge master into develop
I extracted the action out into https://github.com/getsentry/release-comment-issues-gh-action.
…aTags` if SDK is disabled (#13760) Ensures that we don't return trace data from the new `getTraceData` and `getTraceMetaTags` APIs if the SDK is disabled. Add more tests to ensure this is now properly covered, along with a test for behaviour with `tracesSampleRate: 0`.
CI is currently blocked because a test in our solidStart e2e test app is failing. It seems like for some reason, when first accessing the `/error-boundary` route, a hydration error is thrown that's caught by the set error boundary. I didn't get to the bottom of why this hydration error is being thrown but at least we can work around it by simply reloading the page before triggering the sample error. This PR does exactly that. We should follow up with a proper fix for this (cc @andreiborza when you get a chance)
The peer dependency introduced in #13571 seems to be too strict. After installing the latest next version (14.2.13) and @sentry/next version (8.32.0), I get the following: ```sh └─┬ @sentry/nextjs 8.32.0 └── ✕ unmet peer [email protected]: found 5.95.0 ``` --------- Co-authored-by: Luca Forstner <[email protected]>
…arams`) (#13828) Changes in Next.js vercel/next.js#68812 This PR is mostly just adjusting our E2E tests so they don't fail while building. Additionally, we had to update the `withServerActionInstrumentation` API in a semver-minor way so you can pass a promise to the `headers` option. The `ReadonlyHeaders` type isn't exposed in all Next.js versions so for now I typed it as `any`. Resolves #13805 Resolves #13779 Resolves #13780
lforst
approved these changes
Oct 2, 2024
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
AbhiPrasad
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.