Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextjs-app-dir (canary) Test Failed #13805

Closed
github-actions bot opened this issue Sep 26, 2024 · 2 comments · Fixed by #13828
Closed

nextjs-app-dir (canary) Test Failed #13805

github-actions bot opened this issue Sep 26, 2024 · 2 comments · Fixed by #13828
Assignees
@lforst
Labels
Type: Tests

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

Canary tests failed: https://github.com/getsentry/sentry-javascript/actions/runs/11097162749
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Sep 26, 2024
@chargome
Copy link
Member

Canary tests failing due to vercel/next.js#68812

@chargome chargome self-assigned this Sep 26, 2024
@lforst lforst assigned lforst and unassigned chargome Sep 30, 2024
@lforst lforst mentioned this issue Sep 30, 2024
Merged
lforst added a commit that referenced this issue Sep 30, 2024
@lforst
feat(nextjs): Support new async APIs (headers(), params, `searchP…
ca19f34 
…arams`) (#13828)

Changes in Next.js vercel/next.js#68812

This PR is mostly just adjusting our E2E tests so they don't fail while
building.

Additionally, we had to update the `withServerActionInstrumentation` API
in a semver-minor way so you can pass a promise to the `headers` option.
The `ReadonlyHeaders` type isn't exposed in all Next.js versions so for
now I typed it as `any`.

Resolves #13805
Resolves #13779
Resolves #13780
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Oct 2, 2024

A PR closing this issue has just been released 🚀

This issue was referenced by PR #13828, which was included in the 8.33.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lforst lforst

Labels
Type: Tests
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nextjs): Support new async APIs (headers(), params, searchParams) getsentry/sentry-javascript
2 participants
@lforst @chargome