feat(meta-sdks): Remove runtime tags #13105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Jul 30, 2024
size-limit report 📦
|
Lms24
approved these changes
Jul 30, 2024
Comment on lines
-48
to
-49
|
|
||
| expect(getIsolationScope().getScopeData().tags).toEqual({ runtime: 'browser' }); |
| @@ -45,8 +45,6 @@ describe('Sentry server SDK', () => { | |||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({}); | |||
|
|
|||
| init({ dsn: 'https://[email protected]/1337' }); | |||
|
|
|||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); | |||
| @@ -36,7 +36,5 @@ describe('Initialize Solid Start SDK', () => { | |||
|
|
|||
| it('sets the runtime tag on the isolation scope', () => { | |||
| solidStartInit({ dsn: 'https://[email protected]/1337' }); | |||
|
|
|||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); | |||
| @@ -36,7 +36,5 @@ describe('Initialize Solid Start SDK', () => { | |||
|
|
|||
| it('sets the runtime tag on the isolation scope', () => { | |||
| solidStartInit({ dsn: 'https://[email protected]/1337' }); | |||
|
|
|||
| expect(SentrySolid.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'browser' }); | |||
| @@ -48,7 +48,5 @@ describe('Client init()', () => { | |||
| expect(SentryReact.getIsolationScope().getScopeData().tags).toEqual({}); | |||
|
|
|||
| init({ dsn: 'https://[email protected]/1337' }); | |||
|
|
|||
| @@ -52,8 +52,6 @@ describe('Server init()', () => { | |||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({}); | |||
|
|
|||
| init({ dsn: 'https://[email protected]/1337' }); | |||
|
|
|||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); | |||
| @@ -77,8 +77,6 @@ describe('Client init()', () => { | |||
| expect(SentryReact.getIsolationScope().getScopeData().tags).toEqual({}); | |||
|
|
|||
| init({ dsn: 'https://[email protected]/1337' }); | |||
|
|
|||
| expect(SentryReact.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'browser' }); | |||
Comment on lines
-46
to
-47
|
|
||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); |
There was a problem hiding this comment.
l: let's delete the entire test since this was the only relevant check. I don't think we need to assert that the isolation scope has no tags at the beginning for Astro specifically.
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime tags are already set by e.g. Relay, so the Meta-Framework SDKs do not need to set them anymore.
Comment why this change was made: #13101 (review)