Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): Add runtime tags #13101

Closed
wants to merge 1 commit into from
Closed

feat(nuxt): Add runtime tags #13101

wants to merge 1 commit into from

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 30, 2024

No description provided.

@s1gr1d s1gr1d requested review from lforst, Lms24 and chargome July 30, 2024 11:53
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just talked about this with @lforst and we agreed that we should not add this tag. This is a bit unfortunate because I assume you saw this in another meta framework SDK. Sorry about that! I think back then we didn't consider this too much but the Node SDK as well as Relay (via the user agent header for browser-sent events) already extract runtime information. So events in Sentry are already annotated with the extracted runtime information and there's no need for us to set specific tags.

Instead, we should remove the tags from the SDKs that set runtime today. Do you want to open a PR for that? It's not P0 so we can also just create an issue to do later.

@s1gr1d
Copy link
Member Author

s1gr1d commented Jul 30, 2024

Will close this PR because of comment above. Opened another PR to delete setting of runtime tags: #13105

@s1gr1d s1gr1d closed this Jul 30, 2024
s1gr1d added a commit that referenced this pull request Jul 31, 2024
Runtime tags are already set by e.g. Relay, so the Meta-Framework SDKs
do not need to set them anymore.

Comment why this change was made:
#13101 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants