-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(vue): Add Pinia plugin (#13841)
Resolves: #13279 Depends on: #13840 [Sample Event](https://sentry-sdks.sentry.io/issues/5939879614/?project=5429219&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=1h&stream_index=0) Docs PR: getsentry/sentry-docs#11516 Adds a Pinia plugin with a feature set similar to the Redux integration. - Attaches Pinia state as an attachment to the event (`true` by default) - Provides `actionTransformer` and `stateTransformer` to the user for potentially required PII modifications. - Adds breadcrumbs for Pinia actions - Assigns Pinia state to event contexts.
- Loading branch information
1 parent
e577eb7
commit 1877473
Showing
10 changed files
with
352 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
dev-packages/e2e-tests/test-applications/vue-3/src/stores/cart.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import { acceptHMRUpdate, defineStore } from 'pinia'; | ||
|
||
export const useCartStore = defineStore({ | ||
id: 'cart', | ||
state: () => ({ | ||
rawItems: [] as string[], | ||
}), | ||
getters: { | ||
items: (state): Array<{ name: string; amount: number }> => | ||
state.rawItems.reduce( | ||
(items, item) => { | ||
const existingItem = items.find(it => it.name === item); | ||
|
||
if (!existingItem) { | ||
items.push({ name: item, amount: 1 }); | ||
} else { | ||
existingItem.amount++; | ||
} | ||
|
||
return items; | ||
}, | ||
[] as Array<{ name: string; amount: number }>, | ||
), | ||
}, | ||
actions: { | ||
addItem(name: string) { | ||
this.rawItems.push(name); | ||
}, | ||
|
||
removeItem(name: string) { | ||
const i = this.rawItems.lastIndexOf(name); | ||
if (i > -1) this.rawItems.splice(i, 1); | ||
}, | ||
|
||
throwError() { | ||
throw new Error('error'); | ||
}, | ||
}, | ||
}); | ||
|
||
if (import.meta.hot) { | ||
import.meta.hot.accept(acceptHMRUpdate(useCartStore, import.meta.hot)); | ||
} |
88 changes: 88 additions & 0 deletions
88
dev-packages/e2e-tests/test-applications/vue-3/src/views/CartView.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
<template> | ||
<Layout> | ||
<div> | ||
<div style="margin: 1rem 0;"> | ||
<PiniaLogo /> | ||
</div> | ||
|
||
<form @submit.prevent="addItemToCart" data-testid="add-items"> | ||
<input id="item-input" type="text" v-model="itemName" /> | ||
<button id="item-add">Add</button> | ||
<button id="throw-error" @click="throwError">Throw error</button> | ||
</form> | ||
|
||
<form> | ||
<ul data-testid="items"> | ||
<li v-for="item in cart.items" :key="item.name"> | ||
{{ item.name }} ({{ item.amount }}) | ||
<button | ||
@click="cart.removeItem(item.name)" | ||
type="button" | ||
>X</button> | ||
</li> | ||
</ul> | ||
|
||
<button | ||
:disabled="!cart.items.length" | ||
@click="clearCart" | ||
type="button" | ||
data-testid="clear" | ||
>Clear the cart</button> | ||
</form> | ||
</div> | ||
</Layout> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { defineComponent, ref } from 'vue' | ||
import { useCartStore } from '../stores/cart' | ||
export default defineComponent({ | ||
setup() { | ||
const cart = useCartStore() | ||
const itemName = ref('') | ||
function addItemToCart() { | ||
if (!itemName.value) return | ||
cart.addItem(itemName.value) | ||
itemName.value = '' | ||
} | ||
function throwError() { | ||
throw new Error('This is an error') | ||
} | ||
function clearCart() { | ||
if (window.confirm('Are you sure you want to clear the cart?')) { | ||
cart.rawItems = [] | ||
} | ||
} | ||
// @ts-ignore | ||
window.stores = { cart } | ||
return { | ||
itemName, | ||
addItemToCart, | ||
cart, | ||
throwError, | ||
clearCart, | ||
} | ||
}, | ||
}) | ||
</script> | ||
|
||
<style scoped> | ||
img { | ||
width: 200px; | ||
} | ||
button, | ||
input { | ||
margin-right: 0.5rem; | ||
margin-bottom: 0.5rem; | ||
} | ||
</style> |
35 changes: 35 additions & 0 deletions
35
dev-packages/e2e-tests/test-applications/vue-3/tests/pinia.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import { expect, test } from '@playwright/test'; | ||
import { waitForError } from '@sentry-internal/test-utils'; | ||
|
||
test('sends pinia action breadcrumbs and state context', async ({ page }) => { | ||
await page.goto('/cart'); | ||
|
||
await page.locator('#item-input').fill('item'); | ||
await page.locator('#item-add').click(); | ||
|
||
const errorPromise = waitForError('vue-3', async errorEvent => { | ||
return errorEvent?.exception?.values?.[0].value === 'This is an error'; | ||
}); | ||
|
||
await page.locator('#throw-error').click(); | ||
|
||
const error = await errorPromise; | ||
|
||
expect(error).toBeTruthy(); | ||
expect(error.breadcrumbs?.length).toBeGreaterThan(0); | ||
|
||
const actionBreadcrumb = error.breadcrumbs?.find(breadcrumb => breadcrumb.category === 'action'); | ||
|
||
expect(actionBreadcrumb).toBeDefined(); | ||
expect(actionBreadcrumb?.message).toBe('Transformed: addItem'); | ||
expect(actionBreadcrumb?.level).toBe('info'); | ||
|
||
const stateContext = error.contexts?.state?.state; | ||
|
||
expect(stateContext).toBeDefined(); | ||
expect(stateContext?.type).toBe('pinia'); | ||
expect(stateContext?.value).toEqual({ | ||
transformed: true, | ||
rawItems: ['item'], | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
import { addBreadcrumb, getClient, getCurrentScope, getGlobalScope } from '@sentry/core'; | ||
import { addNonEnumerableProperty } from '@sentry/utils'; | ||
|
||
// Inline PiniaPlugin type | ||
type PiniaPlugin = (context: { | ||
store: { | ||
$id: string; | ||
$state: unknown; | ||
$onAction: (callback: (context: { name: string; after: (callback: () => void) => void }) => void) => void; | ||
}; | ||
}) => void; | ||
|
||
type SentryPiniaPluginOptions = { | ||
attachPiniaState?: boolean; | ||
addBreadcrumbs?: boolean; | ||
actionTransformer?: (action: any) => any; | ||
stateTransformer?: (state: any) => any; | ||
}; | ||
|
||
export const createSentryPiniaPlugin: (options?: SentryPiniaPluginOptions) => PiniaPlugin = ( | ||
options: SentryPiniaPluginOptions = { | ||
attachPiniaState: true, | ||
addBreadcrumbs: true, | ||
actionTransformer: action => action, | ||
stateTransformer: state => state, | ||
}, | ||
) => { | ||
const plugin: PiniaPlugin = ({ store }) => { | ||
options.attachPiniaState !== false && | ||
getGlobalScope().addEventProcessor((event, hint) => { | ||
try { | ||
// Get current timestamp in hh:mm:ss | ||
const timestamp = new Date().toTimeString().split(' ')[0]; | ||
const filename = `pinia_state_${store.$id}_${timestamp}.json`; | ||
|
||
hint.attachments = [ | ||
...(hint.attachments || []), | ||
{ | ||
filename, | ||
data: JSON.stringify(store.$state), | ||
}, | ||
]; | ||
} catch (_) { | ||
// empty | ||
} | ||
|
||
return event; | ||
}); | ||
|
||
store.$onAction(context => { | ||
context.after(() => { | ||
const transformedActionName = options.actionTransformer | ||
? options.actionTransformer(context.name) | ||
: context.name; | ||
|
||
if ( | ||
typeof transformedActionName !== 'undefined' && | ||
transformedActionName !== null && | ||
options.addBreadcrumbs !== false | ||
) { | ||
addBreadcrumb({ | ||
category: 'action', | ||
message: transformedActionName, | ||
level: 'info', | ||
}); | ||
} | ||
|
||
/* Set latest state to scope */ | ||
const transformedState = options.stateTransformer ? options.stateTransformer(store.$state) : store.$state; | ||
const scope = getCurrentScope(); | ||
const currentState = scope.getScopeData().contexts.state; | ||
|
||
if (typeof transformedState !== 'undefined' && transformedState !== null) { | ||
const client = getClient(); | ||
const options = client && client.getOptions(); | ||
const normalizationDepth = (options && options.normalizeDepth) || 3; // default state normalization depth to 3 | ||
const piniaStateContext = { type: 'pinia', value: transformedState }; | ||
|
||
const newState = { | ||
...(currentState || {}), | ||
state: piniaStateContext, | ||
}; | ||
|
||
addNonEnumerableProperty( | ||
newState, | ||
'__sentry_override_normalization_depth__', | ||
3 + // 3 layers for `state.value.transformedState | ||
normalizationDepth, // rest for the actual state | ||
); | ||
|
||
scope.setContext('state', newState); | ||
} else { | ||
scope.setContext('state', { | ||
...(currentState || {}), | ||
state: { type: 'pinia', value: 'undefined' }, | ||
}); | ||
} | ||
}); | ||
}); | ||
}; | ||
|
||
return plugin; | ||
}; |
Oops, something went wrong.