Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): Add Pinia Plugin Docs #11516

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat(vue): Add Pinia Plugin Docs #11516

merged 3 commits into from
Oct 21, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 9:19am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 9:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 9:19am

Copy link

codecov bot commented Oct 8, 2024

Bundle Report

Changes will increase total bundle size by 195 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.45MB 204 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

@smeubank
Copy link
Member

smeubank commented Oct 9, 2024

should we add to Nuxt as well? Pinia has more limited value add for a nuxt app but it can still be used there

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor suggestion, looks good, thanks for adding this! 👍

@onurtemizkan
Copy link
Collaborator Author

should we add to Nuxt as well? Pinia has more limited value add for a nuxt app but it can still be used there

I haven't tested the plugin on a Nuxt app. Let me do it today and I'll update the Nuxt page too 👍

@s1gr1d s1gr1d requested a review from lizokm October 11, 2024 08:45
Co-authored-by: Sigrid Huemer <[email protected]>
s1gr1d pushed a commit to getsentry/sentry-javascript that referenced this pull request Oct 15, 2024
Resolves: #13279
Depends on: #13840 
[Sample
Event](https://sentry-sdks.sentry.io/issues/5939879614/?project=5429219&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=1h&stream_index=0)

Docs PR: getsentry/sentry-docs#11516
 

Adds a Pinia plugin with a feature set similar to the Redux integration.

- Attaches Pinia state as an attachment to the event (`true` by default)
- Provides `actionTransformer` and `stateTransformer` to the user for
potentially required PII modifications.
- Adds breadcrumbs for Pinia actions
- Assigns Pinia state to event contexts.
billyvg pushed a commit to getsentry/sentry-javascript that referenced this pull request Oct 17, 2024
Resolves: #13279
Depends on: #13840 
[Sample
Event](https://sentry-sdks.sentry.io/issues/5939879614/?project=5429219&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=date&statsPeriod=1h&stream_index=0)

Docs PR: getsentry/sentry-docs#11516
 

Adds a Pinia plugin with a feature set similar to the Redux integration.

- Attaches Pinia state as an attachment to the event (`true` by default)
- Provides `actionTransformer` and `stateTransformer` to the user for
potentially required PII modifications.
- Adds breadcrumbs for Pinia actions
- Assigns Pinia state to event contexts.
@s1gr1d
Copy link
Member

s1gr1d commented Oct 21, 2024

To add those docs to the Nuxt docs, the plugin has to be added to the Sentry Nuxt SDK. I created an issue for that and will work on this and the docs for it: getsentry/sentry-javascript#14039

@s1gr1d s1gr1d merged commit ea6b8ed into master Oct 21, 2024
11 checks passed
@s1gr1d s1gr1d deleted the onur/pinia-integration branch October 21, 2024 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants